From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: Ben Slusky <sluskyb@paranoiacs.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
jariruusu@users.sourceforge.net
Subject: Re: [PATCH] loop.c patches, take two
Date: Mon, 22 Dec 2003 01:51:11 +0200 [thread overview]
Message-ID: <3FE631EF.7080909@kolumbus.fi> (raw)
In-Reply-To: <20031221230522.GD4721@fukurou.paranoiacs.org>
Ben Slusky wrote:
>On Mon, 22 Dec 2003 01:00:39 +0200, Mika Penttil? wrote:
>
>
>>AFAICS, this code path is never taken. You don't queue block device writes
>>for the loop thread.
>>
>>
>
>Yes I do, in loop_end_io_transfer. If we allocated fewer pages for the copy
>bio than contained in the original bio, then those pages are recycled for
>the next write.
>
>@@ -413,7 +411,7 @@ static int loop_end_io_transfer(struct b
> if (bio->bi_size)
> return 1;
>
>- if (err || bio_rw(bio) == WRITE) {
>+ if (err || (bio_rw(bio) == WRITE && bio->bi_vcnt == rbh->bi_vcnt)) {
> bio_endio(rbh, rbh->bi_size, err);
> if (atomic_dec_and_test(&lo->lo_pending))
> up(&lo->lo_bh_mutex);
>
>
I see, subtle...
--Mika
next prev parent reply other threads:[~2003-12-21 23:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-30 13:41 [PATCH] remove useless highmem bounce from loop/cryptoloop Ben Slusky
2003-10-30 18:14 ` Jari Ruusu
2003-10-30 21:30 ` Andrew Morton
2003-10-31 0:52 ` Ben Slusky
2003-10-31 9:55 ` Andrew Morton
2003-10-31 9:55 ` Andrew Morton
2003-10-31 9:58 ` Andrew Morton
2003-11-13 3:06 ` Ben Slusky
2003-11-01 0:26 ` Ben Slusky
2003-11-02 20:46 ` Ben Slusky
2003-12-21 19:55 ` [PATCH] loop.c patches, take two Ben Slusky
2003-12-21 20:07 ` Ben Slusky
2003-12-21 20:49 ` Mika Penttilä
2003-12-21 21:12 ` Ben Slusky
2003-12-21 23:00 ` Mika Penttilä
2003-12-21 23:05 ` Ben Slusky
2003-12-21 23:51 ` Mika Penttilä [this message]
2003-12-21 22:01 ` Christophe Saout
2003-12-22 6:33 ` Andrew Morton
2003-12-22 23:32 ` Ben Slusky
2003-10-31 12:15 ` [PATCH] remove useless highmem bounce from loop/cryptoloop Jari Ruusu
2003-10-31 13:02 ` Jens Axboe
[not found] <MllE.6qa.7@gated-at.bofh.it>
[not found] ` <MpyW.3Ub.9@gated-at.bofh.it>
[not found] ` <MsGq.8cN.1@gated-at.bofh.it>
[not found] ` <MvO6.47g.7@gated-at.bofh.it>
[not found] ` <MEf3.8oB.13@gated-at.bofh.it>
[not found] ` <MROA.319.5@gated-at.bofh.it>
[not found] ` <NxkP.4kY.17@gated-at.bofh.it>
[not found] ` <15hUp-58e-21@gated-at.bofh.it>
[not found] ` <15iGH-6hd-17@gated-at.bofh.it>
[not found] ` <15kfk-vj-1@gated-at.bofh.it>
2003-12-22 1:21 ` [PATCH] loop.c patches, take two Andi Kleen
2003-12-22 1:30 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FE631EF.7080909@kolumbus.fi \
--to=mika.penttila@kolumbus.fi \
--cc=akpm@osdl.org \
--cc=jariruusu@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sluskyb@paranoiacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox