public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ethan Weinstein <lists@stinkfoot.org>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: Hans-Peter Jansen <hpj@urpla.net>, linux-kernel@vger.kernel.org
Subject: Re: minor e1000 bug
Date: Mon, 22 Dec 2003 10:26:58 -0500	[thread overview]
Message-ID: <3FE70D42.9070500@stinkfoot.org> (raw)
In-Reply-To: <C6F5CF431189FA4CBAEC9E7DD5441E0102CBDD71@orsmsx402.jf.intel.com>

Feldman, Scott wrote:
>>--- linux-2.4.20/drivers/net/e1000/e1000_main.c~    
>>2003-08-03 00:40:21.000000000 +0200
>>+++ linux-2.4.20/drivers/net/e1000/e1000_main.c 2003-08-08 
>>+++ 13:20:06.000000000 +0200
>>@@ -1390,7 +1390,7 @@
>>        netif_stop_queue(netdev);
>> 
>>    /* Reset the timer */
>>-   mod_timer(&adapter->watchdog_timer, jiffies + 2 * HZ);
>>+   mod_timer(&adapter->watchdog_timer, jiffies + HZ);
>> }
> 
> 
> That should be OK if you're not linked at half duplex or using a 82541/7
> Ethernet controller.  e1000_smartspeed() and e1000_adaptive_ifs() are
> sensitive to the watchdog interval, so we'll need to make sure those are
> OK before adjusting the timer from 2 to 1 seconds.  This issue is
> tracker here: http://bugme.osdl.org/show_bug.cgi?id=1192.

This modification appears to somewhat remedy the problem, however, 
bandwidth measurement seems to be much more accurate with many other 
cards.  By what method does, say, the 3c59x card export its statistics 
to /proc/net/dev that makes it easier to measure?

Ethan


  parent reply	other threads:[~2003-12-22 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-22  5:26 minor e1000 bug Feldman, Scott
2003-12-22 10:26 ` Hans-Peter Jansen
2003-12-22 15:26 ` Ethan Weinstein [this message]
     [not found] <C6F5CF431189FA4CBAEC9E7DD5441E0103424209@orsmsx402.jf.intel.com>
2003-12-24  0:29 ` Feldman, Scott
2003-12-23 14:54   ` Ethan Weinstein
  -- strict thread matches above, loose matches on Subject: below --
2003-12-22 19:30 Feldman, Scott
2003-12-22 19:52 ` Ethan Weinstein
2003-12-19 20:40 Ethan Weinstein
2003-12-20 12:46 ` Hans-Peter Jansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FE70D42.9070500@stinkfoot.org \
    --to=lists@stinkfoot.org \
    --cc=hpj@urpla.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scott.feldman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox