From: Nick Piggin <piggin@cyberone.com.au>
To: colpatch@us.ibm.com
Cc: linux-kernel@vger.kernel.org, mbligh@aracnet.com,
Andrew Morton <akpm@osdl.org>,
Trivial Patch Monkey <trivial@rustcorp.com.au>
Subject: Re: [TRIVIAL PATCH] Use valid node number when unmapping CPUs
Date: Tue, 23 Dec 2003 11:41:55 +1100 [thread overview]
Message-ID: <3FE78F53.9090302@cyberone.com.au> (raw)
In-Reply-To: <3FE74801.2010401@us.ibm.com>
Matthew Dobson wrote:
> The cpu_2_node array for i386 is initialized to 0 for each CPU,
> effectively mapping all CPUs to node 0 unless changed. When we unmap
> CPUs, however, we stick a -1 in the array, mapping the CPU to an
> invalid node. This really isn't helpful. We should map the CPU to
> node 0, to make sure that callers of cpu_to_node() and friends aren't
> returned a bogus node number. This trivial patch changes the
> unmapping code to place a 0 in the node mapping for removed CPUs.
>
> Cheers!
I'd prefer it got initialised to -1 for each cpu, and either set to -1
or not touched during unmap.
0 is more bogus than the alternatives, isn't it? At least for the subset
of CPUs not on node 0. Callers should be fixed.
next prev parent reply other threads:[~2003-12-23 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 19:37 [TRIVIAL PATCH] Use valid node number when unmapping CPUs Matthew Dobson
2003-12-23 0:41 ` Nick Piggin [this message]
2004-01-05 22:52 ` Matthew Dobson
2004-01-06 0:39 ` Nick Piggin
2004-03-29 15:46 ` Nick Piggin
2004-03-29 15:45 ` Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FE78F53.9090302@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox