public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nuno Silva <nuno.silva@vgertech.com>
To: Shawn <core@enodev.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: reiser4 breaks vmware
Date: Tue, 23 Dec 2003 21:45:09 +0000	[thread overview]
Message-ID: <3FE8B765.6000907@vgertech.com> (raw)
In-Reply-To: <1072202167.8127.15.camel@localhost>

Hi.

Shawn wrote:
> Forgive my line-wraps, but the following (among other do_mmap_pgoff
> related snippets) break vmware.
> 
> Couple questions out of this:
> 1. Does anyone care enough to produce a patch for vmware's module?
> 2. What does this change accomplish for reiser4?
> 
> diff -ruN linux-2.6.0-test9/arch/i386/kernel/sys_i386.c
> linux-2.6.0-test9-reiser4/arch/i386/kernel/sys_i386.c 
> --- linux-2.6.0-test9/arch/i386/kernel/sys_i386.c       Sat Oct 25
> 22:44:51 2003 
> +++ linux-2.6.0-test9-reiser4/arch/i386/kernel/sys_i386.c       Thu Nov
> 13 15:39:47 2003 
> @@ -56,7 +56,7 @@ 
>         } 
> 
>         down_write(&current->mm->mmap_sem); 
> -       error = do_mmap_pgoff(file, addr, len, prot, flags, pgoff); 
> +       error = do_mmap_pgoff(current->mm, file, addr, len, prot, flags,
> pgoff); 
>         up_write(&current->mm->mmap_sem); 
> 
>         if (file)

I'd say that namesys is using UML (user-mode-linux.sf.net) to develop 
raiser4 (smart guys, uml rocks).

These are probably left overs from UML's SKAS-host patch. If I'm correct 
you may try to reverse the SKAS patch from that tree (the patch is 
located at UML's site). It won't do any harm, anyway...

Regards,
Nuno Silva



  parent reply	other threads:[~2003-12-23 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-23 17:56 reiser4 breaks vmware Shawn
2003-12-23 19:21 ` Hans Reiser
2003-12-23 21:45 ` Nuno Silva [this message]
2003-12-24  8:09   ` Nikita Danilov
     [not found] <1072202167.8127.15.camel@localhost.suse.lists.linux.kernel>
     [not found] ` <3FE8B765.6000907@vgertech.com.suse.lists.linux.kernel>
     [not found]   ` <16361.18888.602000.438746@laputa.namesys.com.suse.lists.linux.kernel>
2003-12-24 22:15     ` Andi Kleen
2003-12-25  9:29       ` Nikita Danilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FE8B765.6000907@vgertech.com \
    --to=nuno.silva@vgertech.com \
    --cc=core@enodev.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox