PATCH: Alternate pdcraid superblock finder

PATCH: Alternate pdcraid superblock finder

[Walt H]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi,

This patch proposes an alternate method of finding the raid superblock on
Promise raid devices. It hasn't received much testing, so I left the old routine
intact and just check for ideinfo->head == 255 to use my method. I'm not aware
of any reasons why my method wouldn't work for all drives, but I thought this
was a safer change.

-Walt Holman


[-- Attachment #2: pdcraid.patch --]
[-- Type: text/plain, Size: 612 bytes --]

--- /usr/src/temp/linux-2.4.21-xfs/linux/drivers/ide/raid/pdcraid.c	2003-12-22 17:59:09.653139067 -0800
+++ linux/drivers/ide/raid/pdcraid.c	2003-07-21 20:47:14.000000000 -0700
@@ -361,7 +361,11 @@
 	if (ideinfo->sect==0)
 		return 0;
-	lba = (ideinfo->capacity / (ideinfo->head*ideinfo->sect));
-	lba = lba * (ideinfo->head*ideinfo->sect);
-	lba = lba - ideinfo->sect;
+	if (ideinfo->head!=255) {
+		lba = (ideinfo->capacity / (ideinfo->head*ideinfo->sect));
+		lba = lba * (ideinfo->head*ideinfo->sect);
+		lba = lba - ideinfo->sect; }
+	else {
+		lba = ideinfo->capacity - ideinfo->sect;
+	}
 
 	return lba;

RE: PATCH: Alternate pdcraid superblock finder

[Nicklas Bondesson]

Hi!

I've just checked out the new 2.4.24 and your pdcraid patch is *not*
included. Did Marcelo accidently forget to merge it?

/Nicke

-----Original Message-----
From: Walt H [mailto:waltabbyh@comcast.net] 
Sent: den 30 december 2003 17:09
To: Nicklas Bondesson
Subject: Re: PATCH: Alternate pdcraid superblock finder

Nicklas Bondesson wrote:
> Yeah, I know! I have WD's in all my other boxes they are real nice. 
> Could you please give me a hollow if you hear anything about the patch 
> you sent in today?
> 
> /Nicke

You probably already know, but my patch has been merged. It should show up
in 2.4.24, so should make upgrades a little less painful hopefully :)

-Walt

RE: PATCH: Alternate pdcraid superblock finder

[Marcelo Tosatti]

Nicklas,

I only merged a few very small patches to fix critical problems.

Walt's patch is in 2.4.24-pre3. Have you tried that?

On Mon, 5 Jan 2004, Nicklas Bondesson wrote:

> Hi!
>
> I've just checked out the new 2.4.24 and your pdcraid patch is *not*
> included. Did Marcelo accidently forget to merge it?
>
> /Nicke
>
> -----Original Message-----
> From: Walt H [mailto:waltabbyh@comcast.net]
> Sent: den 30 december 2003 17:09
> To: Nicklas Bondesson
> Subject: Re: PATCH: Alternate pdcraid superblock finder
>
> Nicklas Bondesson wrote:
> > Yeah, I know! I have WD's in all my other boxes they are real nice.
> > Could you please give me a hollow if you hear anything about the patch
> > you sent in today?
> >
> > /Nicke
>
> You probably already know, but my patch has been merged. It should show up
> in 2.4.24, so should make upgrades a little less painful hopefully :)
>
> -Walt
>
>
>
>