From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@redhat.com>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: Problem with dev_kfree_skb_any() in 2.6.0
Date: Tue, 30 Dec 2003 01:12:21 -0500 [thread overview]
Message-ID: <3FF11745.4060705@pobox.com> (raw)
In-Reply-To: <20031229220122.30078657.davem@redhat.com>
David S. Miller wrote:
> On Tue, 30 Dec 2003 00:15:19 -0500
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>
>>OK, agreed. But fixing it in the driver is still incorrect, also.
>>
>>We need a single solution in the net stack, not a per-driver solution.
>
>
> I totally disagree.
>
> Let's quickly review, this is illegal:
You're missing the point.
Think about the name of this function: dev_kfree_skb_any()
If this function cannot be used -anywhere-, then the concept (and the
net stack) is fundamentally broken for this function. We must _remove_
the function, and thus _I_ have a lot of driver work to do.
[jgarzik@sata linux-2.5]$ find . -name '*.[ch]' -type f | grep -v SCCS |
xargs grep -wl dev_kfree_skb_any | wc -l
71
Jeff
next prev parent reply other threads:[~2003-12-30 6:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-27 23:17 Problem with dev_kfree_skb_any() in 2.6.0 Benjamin Herrenschmidt
2003-12-28 1:07 ` David S. Miller
2003-12-28 5:44 ` Benjamin Herrenschmidt
2003-12-30 4:09 ` Jeff Garzik
2003-12-30 4:51 ` David S. Miller
2003-12-30 5:15 ` Jeff Garzik
2003-12-30 6:01 ` David S. Miller
2003-12-30 6:12 ` Jeff Garzik [this message]
2003-12-30 6:13 ` David S. Miller
2003-12-30 17:43 ` Jeff Garzik
2004-01-01 20:42 ` David S. Miller
2004-01-02 2:58 ` Jeff Garzik
2004-01-06 3:54 ` David S. Miller
2003-12-30 6:14 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF11745.4060705@pobox.com \
--to=jgarzik@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox