From: Manfred Spraul <manfred@colorfullife.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] optimize ia32 memmove
Date: Tue, 30 Dec 2003 12:12:43 +0100 [thread overview]
Message-ID: <3FF15DAB.8080203@colorfullife.com> (raw)
In-Reply-To: <1072779479.16344.95.camel@ixodes.goop.org>
Jeremy Fitzhardinge wrote:
>On Tue, 2003-12-30 at 01:58, Linus Torvalds wrote:
>
>>But then anything that does the loads in ascending order is still ok, so
>>it shouldn't matter - by the time "dest" has been overwritten, the source
>>data has already been read. And all the "memcpy()" implementations had
>>better do that anyway, in order to get nice memory access patterns. "rep
>>movsl" certainly does.
AMD recommends to perform bulk copies backwards: That defeats the hw
prefecher, and results in even better access patterns. Doesn't matter in
this case, memmove is never used for bulk copies.
>A PPC memcpy may end up clearing the destination before reading the
>source (using the cache-line zeroing instruction, to prevent the
>destination from being spuriously read to populate the cache line).
>
The change is i386 only, no effect on other archs.
I found the unoptimized memmove in oprofiles of dbt2 testruns: slab
contains a few memmoves to keep it's recently used arrays in strict LIFO
order. Typically perhaps 100 bytes.
--
Manfred
next prev parent reply other threads:[~2003-12-30 11:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200312300713.hBU7DGC4024213@hera.kernel.org>
2003-12-30 7:32 ` [PATCH] optimize ia32 memmove Jeff Garzik
2003-12-30 7:51 ` Andrew Morton
2003-12-30 7:56 ` Jeff Garzik
2003-12-30 8:11 ` Andrew Morton
2003-12-30 8:11 ` Andreas Dilger
2003-12-30 10:05 ` Linus Torvalds
2003-12-30 9:58 ` Linus Torvalds
2003-12-30 10:17 ` Jeremy Fitzhardinge
2003-12-30 11:12 ` Manfred Spraul [this message]
2003-12-30 20:17 ` H. Peter Anvin
2003-12-30 10:21 ` Ed Sweetman
2003-12-30 10:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF15DAB.8080203@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox