From: Jeff Garzik <jgarzik@pobox.com>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc: Mickael Marchand <marchand@kde.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] adaptec 1210sa
Date: Tue, 30 Dec 2003 18:55:39 -0500 [thread overview]
Message-ID: <3FF2107B.6020503@pobox.com> (raw)
In-Reply-To: <641152704.1072828669@aslan.btc.adaptec.com>
Justin T. Gibbs wrote:
>>>the idea suggested by Justin was to clear bits 6 and 7 at 0x8a of pci
>>>configuration space. (which I hope did fine :)
>>>
>>>Thanks Justin :)
>>
>>
>>Does the aar1210 have a different PCI id? That would make it easy to
>>distinguish, and thus easy to selectively apply your patch only to Adaptec
>>chipsets that need it.
>
>
> The change is harmless for controllers using non-adaptec BIOSes. You'll
> find that on these other controllers, the interrupt masks are already
> clear. If this wasn't the case, the current Linux driver wouldn't work
> even on stock boards.
The current Linux driver (well, my sata_sil at least) doesn't work for
several situations, at the moment :) I need to handle the watchdog
timer, and also need to mask a bunch of SATA-phy-specific interrupts.
Now that I see in the docs that these bits are present in the stock
3112, it makes sense to unconditionally ensure they are clear, thus
completely eliminating the BIOS from the equation.
Jeff
next prev parent reply other threads:[~2003-12-30 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 2:05 [PATCH] adaptec 1210sa Mickael Marchand
2003-12-30 23:34 ` Jeff Garzik
2003-12-30 23:57 ` Justin T. Gibbs
2003-12-30 23:55 ` Jeff Garzik [this message]
2003-12-31 0:10 ` Hugo Mills
2003-12-30 23:51 ` Jeff Garzik
2003-12-31 0:20 ` Jeff Garzik
2003-12-31 11:25 ` Mickael Marchand
2004-01-03 20:46 ` Mickael Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF2107B.6020503@pobox.com \
--to=jgarzik@pobox.com \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marchand@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox