From: Manfred Spraul <manfred@colorfullife.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [rfc/patch] wake_up_info() draft ...
Date: Fri, 02 Jan 2004 10:32:14 +0100 [thread overview]
Message-ID: <3FF53A9E.7040905@colorfullife.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0401011921250.1458-100000@bigblue.dev.mdolabs.com>
Davide Libenzi wrote:
>On Fri, 2 Jan 2004, Manfred Spraul wrote:
>
>
>
>>Hi Davide,
>>
>>
>
>Hi Manfred,
>
>
>
>
>>I think the patch adds unnecessary bloat, and mandates one particular
>>use of the wait queue info interface.
>>
>>
>
>why are you saying so?
>
>
>
sizeof(waitqueue_t) increases.
>@@ -1658,6 +1659,8 @@
> unsigned flags;
> curr = list_entry(tmp, wait_queue_t, task_list);
> flags = curr->flags;
>+ if (info)
>+ dup_wait_info(&curr->info, info);
> if (curr->func(curr, mode, sync) &&
> (flags & WQ_FLAG_EXCLUSIVE) &&
> !--nr_exclusive)
>
IMHO these two lines belong into curr->func, perhaps with a reference
implementation that uses
struct wait_queue_entry_info {
wait_queue_t wait;
struct wait_info info;
};
We have already a callback pointer, so why add special case code into
the common codepaths? Custom callbacks could handle the special case of
an info wakeup.
--
Manfred
next prev parent reply other threads:[~2004-01-02 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-02 2:54 [rfc/patch] wake_up_info() draft Manfred Spraul
2004-01-02 3:31 ` Davide Libenzi
2004-01-02 9:32 ` Manfred Spraul [this message]
2004-01-02 17:07 ` Davide Libenzi
[not found] <fa.nd6oiha.q2gq9k@ifi.uio.no>
2004-01-01 21:31 ` John Gardiner Myers
2004-01-01 22:57 ` Davide Libenzi
-- strict thread matches above, loose matches on Subject: below --
2004-01-01 3:46 Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FF53A9E.7040905@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox