From: Raj <obelix123@toughguy.net>
To: Joilnen Leite <pidhash@yahoo.com>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@redhat.com
Subject: Re: about ipmr
Date: Fri, 09 Jan 2004 12:11:39 +0530 [thread overview]
Message-ID: <3FFE4D23.5030400@toughguy.net> (raw)
In-Reply-To: <20040109053433.3812.qmail@web12609.mail.yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 127 bytes --]
I would prefer this way of checking the NULL
That would be more consistent with ip_gre.c and ipip.c
any suggestions ?
/Raj
[-- Attachment #2: ipmr.patch --]
[-- Type: text/plain, Size: 349 bytes --]
--- ipmr.c.org 2004-01-09 12:07:45.271713432 +0530
+++ ipmr.c 2004-01-09 12:09:39.389364912 +0530
@@ -205,6 +205,9 @@ static struct net_device *ipmr_reg_vif(v
dev = alloc_netdev(sizeof(struct net_device_stats), "pimreg",
reg_vif_setup);
+ if( dev == NULL)
+ return NULL;
+
if (register_netdevice(dev)) {
kfree(dev);
return NULL;
next prev parent reply other threads:[~2004-01-09 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 15:34 Linux 2.4.25-pre4 Andrzej Krzysztofowicz
2004-01-09 5:34 ` about ipmr Joilnen Leite
2004-01-09 6:41 ` Raj [this message]
2004-01-09 16:29 ` James Morris
2004-01-14 0:03 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FFE4D23.5030400@toughguy.net \
--to=obelix123@toughguy.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=pidhash@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox