From: Paul Cercueil <paul@crapouillou.net>
To: "João H. Spies" <jhlspies@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.
Date: Wed, 24 Jun 2020 14:03:03 +0200 [thread overview]
Message-ID: <3TIFCQ.1ZGWWD0PTNQ03@crapouillou.net> (raw)
In-Reply-To: <20200623211945.823-1-jhlspies@gmail.com>
Hi João,
Le mar. 23 juin 2020 à 18:19, João H. Spies <jhlspies@gmail.com> a
écrit :
> Previously marked as active high, but is in reality active low.
>
> Cc: stable@vger.kernel.org
> Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
> Signed-off-by: João H. Spies <jhlspies@gmail.com>
Good catch.
Tested-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts
> b/arch/mips/boot/dts/ingenic/gcw0.dts
> index 8d22828787d8..bc72304a2440 100644
> --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> @@ -92,7 +92,7 @@
> "MIC1N", "Built-in Mic";
> simple-audio-card,pin-switches = "Speaker", "Headphones";
>
> - simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>;
> + simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>;
> simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>;
>
> simple-audio-card,bitclock-master = <&dai_codec>;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-24 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 21:19 [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO João H. Spies
2020-06-24 12:03 ` Paul Cercueil [this message]
2020-06-25 8:23 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3TIFCQ.1ZGWWD0PTNQ03@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=jhlspies@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox