From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbdKVCUy (ORCPT ); Tue, 21 Nov 2017 21:20:54 -0500 Received: from [134.134.136.24] ([134.134.136.24]:36134 "EHLO mga09.intel.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751766AbdKVCUr (ORCPT ); Tue, 21 Nov 2017 21:20:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,435,1505804400"; d="scan'208";a="4577832" Subject: Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-4-git-send-email-yao.jin@linux.intel.com> <20171121151733.GF20440@krava> From: "Jin, Yao" Message-ID: <3a0e84e8-fb02-c97b-23e2-3940aa1d2e5e@linux.intel.com> Date: Wed, 22 Nov 2017 10:20:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171121151733.GF20440@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2017 11:17 PM, Jiri Olsa wrote: > On Mon, Nov 20, 2017 at 10:43:38PM +0800, Jin Yao wrote: > > SNIP > >> static int evsel_context(struct perf_evsel *evsel) >> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h >> index 61fd2e0..4eb081d 100644 >> --- a/tools/perf/util/stat.h >> +++ b/tools/perf/util/stat.h >> @@ -126,6 +126,8 @@ typedef void (*print_metric_t)(void *ctx, const char *color, const char *unit, >> const char *fmt, double val); >> typedef void (*new_line_t )(void *ctx); >> >> +void perf_stat__init_runtime_stat(struct runtime_stat *stat); >> +void perf_stat__free_runtime_stat(struct runtime_stat *stat); > > maybe that could be: > runtime_stat__init(struct runtime_stat *stat); > runtime_stat__free(struct runtime_stat *stat); > > jirka > Sure, I will update according to your suggestion. Thanks Jin Yao