From: Mikulas Patocka <mpatocka@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: dm-devel@lists.linux.dev, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Gaurav Kashyap <quic_gaurkash@quicinc.com>
Subject: Re: [PATCH v2 2/2] dm: pass through operations on wrapped inline crypto keys
Date: Tue, 6 May 2025 19:14:06 +0200 (CEST) [thread overview]
Message-ID: <3a0ef010-ec08-de32-134f-80286a3960c9@redhat.com> (raw)
In-Reply-To: <20250505211428.GA10047@google.com>
On Mon, 5 May 2025, Eric Biggers wrote:
> We have to forward derive_sw_secret anyway, since that's invoked by the
> filesystem, not by the ioctls.
>
> The other operations are for the ioctls, but I don't see a reason to make things
> harder for userspace by forcing userspace to implement logic like:
>
> if (is_dm(blkdev))
> blkdev = underlying_device(blkdev)
> ioctl(blkdev)
>
> The device-mapper block device has a blk-crypto profile that declares wrapped
> key support. We should just make the ioctls work on that block device, so that
> upper layers don't need to care whether it's device-mapper or native.
>
> - Eric
OK, I accepted both patches for the next merge window.
Mikulas
prev parent reply other threads:[~2025-05-06 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 21:23 [PATCH v2 0/2] dm: pass through operations on wrapped inline crypto keys Eric Biggers
2025-05-01 21:23 ` [PATCH v2 1/2] blk-crypto: export wrapped key functions Eric Biggers
2025-05-01 21:23 ` [PATCH v2 2/2] dm: pass through operations on wrapped inline crypto keys Eric Biggers
2025-05-05 16:15 ` Mikulas Patocka
2025-05-05 17:03 ` Eric Biggers
2025-05-05 21:01 ` Mikulas Patocka
2025-05-05 21:14 ` Eric Biggers
2025-05-06 17:14 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a0ef010-ec08-de32-134f-80286a3960c9@redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=brgl@bgdev.pl \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gaurkash@quicinc.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox