From: David Hildenbrand <david@redhat.com>
To: Gregory Price <gourry@gourry.net>
Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
kernel-team@meta.com, corbet@lwn.net, osalvador@suse.de,
akpm@linux-foundation.org, chenhuacai@kernel.org,
kernel@xen0n.name, gregkh@linuxfoundation.org, rafael@kernel.org
Subject: Re: [PATCH v3] mm: add build-time option for hotplug memory default online type
Date: Thu, 2 Jan 2025 12:35:48 +0100 [thread overview]
Message-ID: <3a2d03dd-ee70-43b4-8b05-1be948bd0997@redhat.com> (raw)
In-Reply-To: <Z2edvO0X6H_IoMRz@gourry-fedora-PF4VCD3F>
On 22.12.24 06:03, Gregory Price wrote:
> On Sat, Dec 21, 2024 at 04:30:21PM +0100, David Hildenbrand wrote:
>>
>>> -config MEMORY_HOTPLUG_DEFAULT_ONLINE
>>> - bool "Online the newly added memory blocks by default"
>>> - depends on MEMORY_HOTPLUG
>>> +choice
>>> + prompt "Memory Hotplug Default Online Type"
>>> + default MHP_DEFAULT_ONLINE_TYPE_OFFLINE
>>> help
>>> + Default memory type for driver managed hotplug memory.
>>
>> We should call it "hotplugged memory" consistently, which it is from a pure
>> core-mm perspective ("add memory").
>>
>> "Driver managed" reminds too much about add_memory_driver_managed(), which
>> is only one case. Maybe just drop the "e.g., page tables" from the examples
>> below.
>>
>
> I suppose it's accurate that this also affects VM-hotplugged memory,
> which may not necessarily be "driver managed" in that regard. So it's
> more accurate to just say "hotplugged memory" - although even that's not
> quite completely accurate according to the definition in the docs.
>
> Either way, will change it to "hotplugged memory".
The "really correct" thing might be "hot-added memory blocks", because
that's what it is from a Linux MM POV.
Not sure though, if that will be particularly easier to grasp for end users.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-01-02 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 21:07 [PATCH v3] mm: add build-time option for hotplug memory default online type Gregory Price
2024-12-21 15:30 ` David Hildenbrand
2024-12-22 5:03 ` Gregory Price
2025-01-02 11:35 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a2d03dd-ee70-43b4-8b05-1be948bd0997@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@meta.com \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).