* [PATCH] iommu/vt-d: Allocate local memory for page request queue
@ 2024-04-03 21:40 Jacob Pan
2024-04-08 7:36 ` Tian, Kevin
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Pan @ 2024-04-03 21:40 UTC (permalink / raw)
To: LKML, iommu, Lu Baolu, Joerg Roedel
Cc: Raj Ashok, Tian, Kevin, Yi Liu, Jacob Pan
The page request queue is per IOMMU, its allocation should be made
NUMA-aware for performance reasons.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
drivers/iommu/intel/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index c1bed89b1026..ee3b469e2da1 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -66,7 +66,7 @@ int intel_svm_enable_prq(struct intel_iommu *iommu)
struct page *pages;
int irq, ret;
- pages = alloc_pages(GFP_KERNEL | __GFP_ZERO, PRQ_ORDER);
+ pages = alloc_pages_node(iommu->node, GFP_KERNEL | __GFP_ZERO, PRQ_ORDER);
if (!pages) {
pr_warn("IOMMU: %s: Failed to allocate page request queue\n",
iommu->name);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] iommu/vt-d: Allocate local memory for page request queue
2024-04-03 21:40 [PATCH] iommu/vt-d: Allocate local memory for page request queue Jacob Pan
@ 2024-04-08 7:36 ` Tian, Kevin
2024-04-11 2:49 ` Baolu Lu
0 siblings, 1 reply; 3+ messages in thread
From: Tian, Kevin @ 2024-04-08 7:36 UTC (permalink / raw)
To: Jacob Pan, LKML, iommu@lists.linux.dev, Lu Baolu, Joerg Roedel
Cc: Raj, Ashok, Liu, Yi L
> From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Sent: Thursday, April 4, 2024 5:40 AM
>
> The page request queue is per IOMMU, its allocation should be made
> NUMA-aware for performance reasons.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/vt-d: Allocate local memory for page request queue
2024-04-08 7:36 ` Tian, Kevin
@ 2024-04-11 2:49 ` Baolu Lu
0 siblings, 0 replies; 3+ messages in thread
From: Baolu Lu @ 2024-04-11 2:49 UTC (permalink / raw)
To: Tian, Kevin, Jacob Pan, LKML, iommu@lists.linux.dev, Joerg Roedel
Cc: baolu.lu, Raj, Ashok, Liu, Yi L
On 4/8/24 3:36 PM, Tian, Kevin wrote:
>> From: Jacob Pan<jacob.jun.pan@linux.intel.com>
>> Sent: Thursday, April 4, 2024 5:40 AM
>>
>> The page request queue is per IOMMU, its allocation should be made
>> NUMA-aware for performance reasons.
>>
>> Signed-off-by: Jacob Pan<jacob.jun.pan@linux.intel.com>
> Reviewed-by: Kevin Tian<kevin.tian@intel.com>
Add below fix tag and queue it for v6.9-rc.
Fixes: a222a7f0bb6c ("iommu/vt-d: Implement page request handling")
Best regards,
baolu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-11 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-03 21:40 [PATCH] iommu/vt-d: Allocate local memory for page request queue Jacob Pan
2024-04-08 7:36 ` Tian, Kevin
2024-04-11 2:49 ` Baolu Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox