Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

Jin, Yao
2018-06-15T08:24:56Z

On 6/15/2018 4:12 PM, Peter Zijlstra wrote:
> On Fri, Jun 15, 2018 at 04:01:45PM +0800, Jin, Yao wrote:
>
>> Bring more overhead to kernel if we zero the bits considering the number of
>> leaked samples may be not too small?
>
> Keeping the samples at least allows you to know how many samples
> happened and such things.
>

Yeah, agree, but a little bit overhead ...

>> And the skid information may be interesting (see example of hitting on
>> page_fault in previous mail). If we zero it, we will not know.
>
> If you throw them out the window you also don't know, do you?
>

Yes, default I can't know that window. I have to use sysctl to enable.

Thanks
Jin Yao