From: Adrian Hunter <adrian.hunter@intel.com>
To: Kamal Dasu <kamal.dasu@broadcom.com>, <andersson@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<florian.fainelli@broadcom.com>, <ulf.hansson@linaro.org>
Cc: <bcm-kernel-feedback-list@broadcom.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] mmc: sdhci-brcmstb: move SDIO_CFG_CQ_CAPABILITY define
Date: Thu, 9 Oct 2025 11:59:42 +0300 [thread overview]
Message-ID: <3a6f1801-30d0-4e7b-b5d2-412d67ce16f9@intel.com> (raw)
In-Reply-To: <20251007140434.606051-3-kamal.dasu@broadcom.com>
On 07/10/2025 17:04, Kamal Dasu wrote:
> Moving SDIO_CFG_CQ_CAPABILITY register defines to be in sorted order for
> better readability.
>
> Signed-off-by: Kamal Dasu <kamal.dasu@broadcom.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-brcmstb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index efc2f3bdc631..f81cc1889ac9 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -31,13 +31,11 @@
>
> #define SDHCI_ARASAN_CQE_BASE_ADDR 0x200
>
> -#define SDIO_CFG_CQ_CAPABILITY 0x4c
> -#define SDIO_CFG_CQ_CAPABILITY_FMUL GENMASK(13, 12)
> -
> #define SDIO_CFG_CTRL 0x0
> #define SDIO_CFG_CTRL_SDCD_N_TEST_EN BIT(31)
> #define SDIO_CFG_CTRL_SDCD_N_TEST_LEV BIT(30)
> -
> +#define SDIO_CFG_CQ_CAPABILITY 0x4c
> +#define SDIO_CFG_CQ_CAPABILITY_FMUL GENMASK(13, 12)
> #define SDIO_CFG_MAX_50MHZ_MODE 0x1ac
> #define SDIO_CFG_MAX_50MHZ_MODE_STRAP_OVERRIDE BIT(31)
> #define SDIO_CFG_MAX_50MHZ_MODE_ENABLE BIT(0)
next prev parent reply other threads:[~2025-10-09 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 14:04 [PATCH v2 0/5] sdhci-brcmstb SD host controller SoC specific enhancements Kamal Dasu
2025-10-07 14:04 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for BCM72116 and BCM74371 SD host controller Kamal Dasu
2025-10-07 14:04 ` [PATCH v2 2/5] mmc: sdhci-brcmstb: move SDIO_CFG_CQ_CAPABILITY define Kamal Dasu
2025-10-09 8:59 ` Adrian Hunter [this message]
2025-10-07 14:04 ` [PATCH v2 3/5] mmc: sdhci-brcmstb: clear CFG_OP_DLY when using HS200 Kamal Dasu
2025-10-07 14:04 ` [PATCH v2 4/5] mmc: sdhci-brcmstb: Add BCM74371 support Kamal Dasu
2025-10-09 9:00 ` Adrian Hunter
2025-10-07 14:04 ` [PATCH v2 5/5] mmc: brcmstb: save and restore registers during PM Kamal Dasu
2025-10-07 14:11 ` Kamal Dasu
2025-10-09 9:00 ` Adrian Hunter
2025-10-07 14:04 ` [PATCH v2 5/5] mmc: sdhci-brcmstb: " Kamal Dasu
2025-10-09 9:02 ` Adrian Hunter
2025-10-17 13:30 ` [PATCH v2 0/5] sdhci-brcmstb SD host controller SoC specific enhancements Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a6f1801-30d0-4e7b-b5d2-412d67ce16f9@intel.com \
--to=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=kamal.dasu@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox