* [PATCH] selftests: size: fix grammar and align output formatting
@ 2025-05-13 21:44 Abdelrahman Fekry
2025-05-22 21:27 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Abdelrahman Fekry @ 2025-05-13 21:44 UTC (permalink / raw)
To: shauh, skhan
Cc: linux-kselftest, linux-kernel, linux-kernel-mentees,
Abdelrahman Fekry, Abdelrahman Fekry
Improve the grammar in the test name by changing "get runtime memory use"
to "get runtime memory usage". Also adjust spacing in output lines
("Total:", "Free:", etc.) to ensure consistent alignment and readability.
Signed-off-by: Abdelrahman Fekry <AbdelrahmanFekry375@gmail.com>
---
tools/testing/selftests/size/get_size.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/size/get_size.c b/tools/testing/selftests/size/get_size.c
index 2980b1a63366..d5b67c073d8e 100644
--- a/tools/testing/selftests/size/get_size.c
+++ b/tools/testing/selftests/size/get_size.c
@@ -86,7 +86,7 @@ void _start(void)
int ccode;
struct sysinfo info;
unsigned long used;
- static const char *test_name = " get runtime memory use\n";
+ static const char *test_name = " get runtime memory usage\n";
print("TAP version 13\n");
print("# Testing system size.\n");
@@ -105,8 +105,8 @@ void _start(void)
used = info.totalram - info.freeram - info.bufferram;
print("# System runtime memory report (units in Kilobytes):\n");
print(" ---\n");
- print_k_value(" Total: ", info.totalram, info.mem_unit);
- print_k_value(" Free: ", info.freeram, info.mem_unit);
+ print_k_value(" Total : ", info.totalram, info.mem_unit);
+ print_k_value(" Free : ", info.freeram, info.mem_unit);
print_k_value(" Buffer: ", info.bufferram, info.mem_unit);
print_k_value(" In use: ", used, info.mem_unit);
print(" ...\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] selftests: size: fix grammar and align output formatting
@ 2025-05-13 21:46 Abdelrahman Fekry
0 siblings, 0 replies; 3+ messages in thread
From: Abdelrahman Fekry @ 2025-05-13 21:46 UTC (permalink / raw)
To: shuah, skhan
Cc: linux-kselftest, linux-kernel, linux-kernel-mentees,
Abdelrahman Fekry, Abdelrahman Fekry
Improve the grammar in the test name by changing "get runtime memory use"
to "get runtime memory usage". Also adjust spacing in output lines
("Total:", "Free:", etc.) to ensure consistent alignment and readability.
Signed-off-by: Abdelrahman Fekry <AbdelrahmanFekry375@gmail.com>
---
tools/testing/selftests/size/get_size.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/size/get_size.c b/tools/testing/selftests/size/get_size.c
index 2980b1a63366..d5b67c073d8e 100644
--- a/tools/testing/selftests/size/get_size.c
+++ b/tools/testing/selftests/size/get_size.c
@@ -86,7 +86,7 @@ void _start(void)
int ccode;
struct sysinfo info;
unsigned long used;
- static const char *test_name = " get runtime memory use\n";
+ static const char *test_name = " get runtime memory usage\n";
print("TAP version 13\n");
print("# Testing system size.\n");
@@ -105,8 +105,8 @@ void _start(void)
used = info.totalram - info.freeram - info.bufferram;
print("# System runtime memory report (units in Kilobytes):\n");
print(" ---\n");
- print_k_value(" Total: ", info.totalram, info.mem_unit);
- print_k_value(" Free: ", info.freeram, info.mem_unit);
+ print_k_value(" Total : ", info.totalram, info.mem_unit);
+ print_k_value(" Free : ", info.freeram, info.mem_unit);
print_k_value(" Buffer: ", info.bufferram, info.mem_unit);
print_k_value(" In use: ", used, info.mem_unit);
print(" ...\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: size: fix grammar and align output formatting
2025-05-13 21:44 [PATCH] selftests: size: fix grammar and align output formatting Abdelrahman Fekry
@ 2025-05-22 21:27 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2025-05-22 21:27 UTC (permalink / raw)
To: Abdelrahman Fekry, shauh
Cc: linux-kselftest, linux-kernel, linux-kernel-mentees, Shuah Khan
On 5/13/25 15:44, Abdelrahman Fekry wrote:
> Improve the grammar in the test name by changing "get runtime memory use"
> to "get runtime memory usage". Also adjust spacing in output lines
> ("Total:", "Free:", etc.) to ensure consistent alignment and readability.
>
> Signed-off-by: Abdelrahman Fekry <AbdelrahmanFekry375@gmail.com>
Did you run checkpatch on this patch? I am seeing
CHECK: From:/Signed-off-by: email comments mismatch: 'From: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>' != 'Signed-off-by: Abdelrahman Fekry <Abdelrahmanfekry375@gmail.com>'
Please fix it and send v2.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-22 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 21:44 [PATCH] selftests: size: fix grammar and align output formatting Abdelrahman Fekry
2025-05-22 21:27 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2025-05-13 21:46 Abdelrahman Fekry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).