From: Shuah Khan <skhan@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>,
Greg KH <gregkh@linuxfoundation.org>
Cc: vsshingne <vaibhavshingne66@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usb: core: prevent double URB enqueue causing list corruption
Date: Fri, 31 Oct 2025 11:21:31 -0600 [thread overview]
Message-ID: <3a9185ef-c212-41bc-978b-0dea75a86e7b@linuxfoundation.org> (raw)
In-Reply-To: <6c81d455-a4f2-4173-be72-9d77728378c1@rowland.harvard.edu>
On 10/31/25 08:13, Alan Stern wrote:
> On Fri, Oct 31, 2025 at 02:59:07PM +0100, Greg KH wrote:
>> On Fri, Oct 31, 2025 at 07:17:39PM +0530, vsshingne wrote:
>>> Prevents the same URB from being enqueued twice on the same endpoint,
>>> which could lead to list corruption detected by list_debug.c.
>>>
>>> This was observed in syzbot reports where URBs were re-submitted
>>> before completion, triggering 'list_add double add' errors.
>>>
>>> Adding a check to return -EEXIST if the URB is already on a queue
>>> prevents this corruption.
>>
>> This text makes no sense at all, it does not describe what this patch
>> does in any way. Please do not use AI to generate patches.
>
> In fact, the patch doesn't do _anything_ (except maybe change some
> whitespace). And it does not apply to any recent kernel source.
>
Agree - this patch does nothing. Looks like the patch isn't sent
to right people either.
This person happens to be in the mentorship program - I will make
sure they won't send such patches in the future.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-10-31 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 13:47 [PATCH] usb: core: prevent double URB enqueue causing list corruption vsshingne
2025-10-31 13:59 ` Greg KH
2025-10-31 14:13 ` Alan Stern
2025-10-31 17:21 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-31 13:50 vsshingne
2025-10-31 13:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9185ef-c212-41bc-978b-0dea75a86e7b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vaibhavshingne66@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox