From: Jens Axboe <axboe@kernel.dk>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Caspar Zhang <caspar@linux.alibaba.com>,
jiufei.xue@linux.alibaba.com, Tejun Heo <tj@kernel.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RESEND][PATCH v2] cfq: clear queue pointers from cfqg after unpinning them in cfq_pd_offline
Date: Thu, 11 Oct 2018 11:46:37 -0600 [thread overview]
Message-ID: <3abb177f-d6ba-7f7b-e8a6-d27e8cf388a0@kernel.dk> (raw)
In-Reply-To: <befb45da-2a7b-8dff-30e7-59b441f604fe@maciej.szmigiero.name>
On 10/10/18 3:16 PM, Maciej S. Szmigiero wrote:
> BFQ is already doing a similar thing in its .pd_offline_fn() method
> implementation.
>
> While it seems that after commit 4c6994806f70
> ("blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()")
> was reverted leaving these pointers intact no longer causes crashes
> clearing them is still a sensible thing to do to make the code more robust.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2018-10-11 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 21:16 [RESEND][PATCH v2] cfq: clear queue pointers from cfqg after unpinning them in cfq_pd_offline Maciej S. Szmigiero
2018-10-11 17:46 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-19 21:58 Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3abb177f-d6ba-7f7b-e8a6-d27e8cf388a0@kernel.dk \
--to=axboe@kernel.dk \
--cc=caspar@linux.alibaba.com \
--cc=jiufei.xue@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox