From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com,
opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/7 v2] net: Fix platform_get_irq's error checking
Date: Tue, 5 Dec 2017 15:32:15 +0530 [thread overview]
Message-ID: <3acd99d9-5837-eac4-0125-ae77e1369fbf@gmail.com> (raw)
In-Reply-To: <dc7589c8-33d8-44ba-c6e1-b7a67649709c@cogentembedded.com>
Hi Sergei,
On Tuesday 05 December 2017 03:27 PM, Sergei Shtylyov wrote:
> On 12/5/2017 12:54 PM, Sergei Shtylyov wrote:
>
>>> The platform_get_irq() function returns negative number if an error
>>> occurs, Zero if No irq is found and positive number if irq gets
>>> successful.
>>
>> No, returning 0 is not a failure indication anymore! It used to
>> be but not any longer...
>
> And I fixed this function exactly to avoid overly complex error
> checks (which you're trying to propose here).
>
Thanks for your comment. yes you are right. Now It'll not return 0. It
will return irq and error as negative.
I will not add a check for 0.
>>> platform_get_irq() error checking for only zero is not correct.
>>
>> [...]
>
> MBR, Sergei
Thank you,
~arvind
prev parent reply other threads:[~2017-12-05 10:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 17:48 [PATCH 0/7 v2] net: Fix platform_get_irq's error checking Arvind Yadav
2017-12-04 17:48 ` [PATCH 1/7 v2] net: bcmgenet: " Arvind Yadav
2017-12-05 1:01 ` Doug Berger
2017-12-04 17:48 ` [PATCH 2/7 v2] net: ezchip: nps_enet: " Arvind Yadav
2017-12-04 17:48 ` [PATCH 3/7 v2] can: xilinx: " Arvind Yadav
2017-12-04 17:48 ` [PATCH 4/7 v2] net: ethernet: i825xx: " Arvind Yadav
2017-12-04 18:25 ` David Miller
2017-12-05 5:34 ` Arvind Yadav
2017-12-05 15:49 ` David Miller
2017-12-06 12:19 ` Sergei Shtylyov
2017-12-08 9:38 ` arvindY
2017-12-05 10:12 ` Sergei Shtylyov
2017-12-05 10:58 ` Russell King - ARM Linux
2017-12-04 17:48 ` [PATCH 5/7 v2] net: ethernet: natsemi: " Arvind Yadav
2017-12-04 17:48 ` [PATCH 6/7 v2] net: ethernet: smsc: " Arvind Yadav
2017-12-04 17:48 ` [PATCH 7/7 v2] net: fjes: " Arvind Yadav
2017-12-05 9:54 ` [PATCH 0/7 v2] net: " Sergei Shtylyov
2017-12-05 9:57 ` Sergei Shtylyov
2017-12-05 10:02 ` Arvind Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3acd99d9-5837-eac4-0125-ae77e1369fbf@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox