From: Baolu Lu <baolu.lu@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: baolu.lu@linux.intel.com, "Jason Gunthorpe" <jgg@nvidia.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Joerg Roedel" <jroedel@suse.de>,
"Christian König" <christian.koenig@amd.com>,
"Kevin Tian" <kevin.tian@intel.com>,
"Vasant Hegde" <vasant.hegde@amd.com>,
"Tony Zhu" <tony.zhu@intel.com>,
linux-pci@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Matt Fagnani" <matt.fagnani@bell.net>
Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable_pasid()
Date: Fri, 13 Jan 2023 09:56:17 +0800 [thread overview]
Message-ID: <3ae3f5d2-1b58-7498-656d-696182a3589f@linux.intel.com> (raw)
In-Reply-To: <20230112183422.GA1778973@bhelgaas>
On 2023/1/13 2:34, Bjorn Helgaas wrote:
> On Thu, Jan 12, 2023 at 09:25:25PM +0800, Baolu Lu wrote:
>> On 2023/1/12 20:38, Jason Gunthorpe wrote:
>>> On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
>>>
>>>> -int pci_enable_pasid(struct pci_dev *pdev, int features);
>>>> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
>>>> transled_only);
> ^^^^^^^^
>
>> + * @flags: device-specific flags
>> + * - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
>> + * memory requests of translated type.
> ^^^^^^^^
>
> I don't like "transled" since it's not a word itself or an obvious
> combination of "translated" and something else.
>
> Not sure whether you need to abbreviate it, but if you do, "xlate" is
> a common shortening of "translate".
Yes. "xlate" looks better. I will replace with it.
I've updated this patch with a v2.
https://lore.kernel.org/linux-iommu/20230113014409.752405-1-baolu.lu@linux.intel.com/
Thank you both for the comments.
--
Best regards,
baolu
prev parent reply other threads:[~2023-01-13 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 8:46 [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable_pasid() Lu Baolu
2023-01-12 12:38 ` Jason Gunthorpe
2023-01-12 13:25 ` Baolu Lu
2023-01-12 13:26 ` Jason Gunthorpe
2023-01-12 18:34 ` Bjorn Helgaas
2023-01-13 1:56 ` Baolu Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae3f5d2-1b58-7498-656d-696182a3589f@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jroedel@suse.de \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matt.fagnani@bell.net \
--cc=tony.zhu@intel.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox