public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Pavlu <petr.pavlu@suse.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jason Baron <jbaron@akamai.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>, Shuah Khan <shuah@kernel.org>,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 12/17] dyndbg,module: make proper substructs in _ddebug_info
Date: Tue, 5 May 2026 10:05:58 +0200	[thread overview]
Message-ID: <3b17d3a1-bd84-431d-86a8-bf5dfcac09fc@suse.com> (raw)
In-Reply-To: <20260504-dd-cleanups-2-v1-12-6fdd24040642@gmail.com>

On 5/4/26 10:45 PM, Jim Cromie wrote:
> recompose struct _ddebug_info, inserting proper sub-structs.
> 
> The struct _ddebug_info has 2 pairs of _vec, num_##_vec fields, for
> descs and classes respectively.  for_subvec() makes walking these
> vectors less cumbersome, now lets move those field pairs into their
> own "vec" structs: _ddebug_descs & _ddebug_class_maps, and re-compose
> struct _ddebug_info to contain them cleanly.  This also lets us get
> rid of for_subvec()'s num_##_vec paste-up.
> 
> Also recompose struct ddebug_table to contain a _ddebug_info.  This
> reinforces its use as a cursor into relevant data for a builtin
> module, and access to the full _ddebug state for modules.
> 
> NOTES:
> 
> Fixup names: Normalize all struct names to "struct _ddebug_*"
> eliminating the minor/stupid variations created in classmaps-v1.
> 
> Invariant: These vectors ref a contiguous subrange of __section memory
> in builtin/DATA or in loadable modules via mod->dyndbg_info; with
> guaranteed life-time for us.
> 
> struct module contains a _ddebug_info field and module/main.c sets it
> up, so that gets adjusted rather obviously.
> 
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>

Acked-by: Petr Pavlu <petr.pavlu@suse.com> # module

  reply	other threads:[~2026-05-05  8:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 20:45 [PATCH 00/17] dynamic-debug cleanups refactors maintenance Jim Cromie
2026-05-04 20:45 ` [PATCH 01/17] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-05-04 20:45 ` [PATCH 02/17] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-05-04 20:45 ` [PATCH 03/17] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-05-04 20:45 ` [PATCH 04/17] dyndbg: make ddebug_class_param union members same size Jim Cromie
2026-05-04 20:45 ` [PATCH 05/17] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2026-05-04 20:45 ` [PATCH 06/17] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2026-05-04 20:45 ` [PATCH 07/17] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-05-04 20:45 ` [PATCH 08/17] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-05-04 20:45 ` [PATCH 09/17] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-05-04 20:45 ` [PATCH 10/17] dyndbg: replace classmap list with a vector Jim Cromie
2026-05-04 20:45 ` [PATCH 11/17] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-05-04 20:45 ` [PATCH 12/17] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-05-05  8:05   ` Petr Pavlu [this message]
2026-05-04 20:45 ` [PATCH 13/17] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-05-04 20:45 ` [PATCH 14/17] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-05-04 20:45 ` [PATCH 15/17] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-05-04 20:45 ` [PATCH 16/17] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-05-04 20:45 ` [PATCH 17/17] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b17d3a1-bd84-431d-86a8-bf5dfcac09fc@suse.com \
    --to=petr.pavlu@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@kernel.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=mcgrof@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox