From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>,
Alison Schofield <amsfield22@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask
Date: Sat, 21 May 2016 17:23:23 +0100 [thread overview]
Message-ID: <3b43c1f3-70cd-7317-0f16-5dfbb8037805@kernel.org> (raw)
In-Reply-To: <CAKzfze8evJnbffJid1vqTjNoC=4t41XHsaG=F38hkxq_vRBO+g@mail.gmail.com>
On 20/05/16 18:44, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@gmail.com>
>
> On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@gmail.com> wrote:
>> Apply the correct mask to enable all available humidity integration
>> times. Currently, the driver defaults to 6500 and all is okay with that.
>> However, if 3850 is selected we get a stuck bit and can't change back
>> to 6500 or select 2500. (Verified with HDC1008)
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Thanks,
Jonathan
>> ---
>> drivers/iio/humidity/hdc100x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
>> index fa47676..59aa1cb 100644
>> --- a/drivers/iio/humidity/hdc100x.c
>> +++ b/drivers/iio/humidity/hdc100x.c
>> @@ -55,7 +55,7 @@ static const struct {
>> },
>> { /* IIO_HUMIDITYRELATIVE channel */
>> .shift = 8,
>> - .mask = 2,
>> + .mask = 3,
>
> Yikes that is embarrassing on my part! I guess our validation was only
> in the high resolution mode... good catch!
>
>> },
>> };
>>
>> --
>> 2.1.4
>>
prev parent reply other threads:[~2016-05-21 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 17:06 [PATCH] iio: humidity: hdc100x: correct humidity integration time mask Alison Schofield
2016-05-20 17:44 ` Matt Ranostay
2016-05-21 16:23 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b43c1f3-70cd-7317-0f16-5dfbb8037805@kernel.org \
--to=jic23@kernel.org \
--cc=amsfield22@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox