From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964794AbdEVPOq convert rfc822-to-8bit (ORCPT ); Mon, 22 May 2017 11:14:46 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:1025 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934647AbdEVPOn (ORCPT ); Mon, 22 May 2017 11:14:43 -0400 From: Olivier MOYSAN To: Mark Brown CC: "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "alsa-devel@alsa-project.org" , "robh@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , Benjamin GAIGNARD Subject: Re: [PATCH v4 2/3] ASoC: stm32: Add I2S driver Thread-Topic: [PATCH v4 2/3] ASoC: stm32: Add I2S driver Thread-Index: AQHSz+o4gqtOUA91VkCLrpYGsrtZWaH7ytaAgASPQYA= Date: Mon, 22 May 2017 15:11:45 +0000 Message-ID: <3b507e82-d8d1-c2c4-8a50-ca130382171a@st.com> References: <1495120793-11687-1-git-send-email-olivier.moysan@st.com> <1495120793-11687-3-git-send-email-olivier.moysan@st.com> <20170519173359.277lyg6fzwksqnin@sirena.org.uk> In-Reply-To: <20170519173359.277lyg6fzwksqnin@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.51] Content-Type: text/plain; charset="Windows-1252" Content-ID: <9D8D9CB309872E4A9834C53F7980614B@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-22_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, Thanks, for applying the patches. On 05/19/2017 07:33 PM, Mark Brown wrote: > On Thu, May 18, 2017 at 05:19:52PM +0200, olivier moysan wrote: > > This looks good so I'm going to apply it, a few things below though - > can you please send a followup patch for the issue with the Kconfig > symbol? > >> --- a/sound/soc/stm/Kconfig >> +++ b/sound/soc/stm/Kconfig >> @@ -5,4 +5,4 @@ menuconfig SND_SOC_STM32 >> select SND_SOC_GENERIC_DMAENGINE_PCM >> select REGMAP_MMIO >> help >> - Say Y if you want to enable ASoC-support for STM32 >> + Say Y if you want to enable ASoC support for STM32 > > This appears to be an unrelated typo fix. > ok >> diff --git a/sound/soc/stm/Makefile b/sound/soc/stm/Makefile >> index e466a47..8251931 100644 >> --- a/sound/soc/stm/Makefile >> +++ b/sound/soc/stm/Makefile >> @@ -4,3 +4,7 @@ obj-$(CONFIG_SND_SOC_STM32) += snd-soc-stm32-sai-sub.o >> >> snd-soc-stm32-sai-objs := stm32_sai.o >> obj-$(CONFIG_SND_SOC_STM32) += snd-soc-stm32-sai.o >> + >> +# I2S >> +snd-soc-stm32-i2s-objs := stm32_i2s.o >> +obj-$(CONFIG_SND_SOC_STM32) += snd-soc-stm32-i2s.o > > Perhaps make this a separate option? It probably makes sense to rename > the option for the SAI at the same time. > ok, I will fix it in a new patch. >> + >> + ret = clk_prepare_enable(i2s->pclk); >> + if (ret) { >> + dev_err(&pdev->dev, "Enable pclk failed: %d\n", ret); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(i2s->i2sclk); >> + if (ret) { >> + dev_err(&pdev->dev, "Enable i2sclk failed: %d\n", ret); >> + goto err_pclk_disable; >> + } > > It'd be nice to have runtime PM to disable these when the device is idle > but that's not essential. > Yes, I agree. BRs olivier