From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135AE211A05; Sat, 27 Dec 2025 07:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766820174; cv=none; b=FHHFE4LbGeGc+jgb803LgXMUWqd05BUPDQ2WoF3waH/QUwz2uVEnxdBJAeMQJ2BFe12plyodKqhTu9ZfFPYU2nLn3Z1jqgWUoIAEweo7FLxQpUIdqt8EV/OLgQBUbo4fhc0eufVnhPYimoQd1STSiaerqqxCt6OP3YB68MyTqCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766820174; c=relaxed/simple; bh=q+tPJyX3wK30eAKOj2+fLf2+5m/rKACcvGVRSXt2SfU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FF7MutkTyj0n44kU56lSAM1woUVgxkj4ZSGQLwLRvZNYDDDq33GjkRkXNcingU1CcXypJTLRAAJRpSbQyc02EucCXqQLsZj16MN3wUguXms4plek/f19HB1m2VTHt9MbL387L52TCu2gOMI/gFR9+LXJG3R4mSe3aCGNLIpTFwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.103.54]) by APP-01 (Coremail) with SMTP id qwCowABX_mkeiU9p98L7AQ--.5607S2; Sat, 27 Dec 2025 15:22:07 +0800 (CST) Message-ID: <3b5fd30554f91bcd083b2dc450cdf7fe2fa395e2.camel@iscas.ac.cn> Subject: Re: Re: [PATCH v4 5/9] drm/bridge: add a driver for T-Head TH1520 HDMI controller From: Icenowy Zheng To: Andy Yan Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Michal Wilczynski , devicetree@vger.kernel.org, Yao Zi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Han Gao , linux-riscv@lists.infradead.org Date: Sat, 27 Dec 2025 15:22:05 +0800 In-Reply-To: <5ce9d611.1868.19b5e9e7a61.Coremail.andyshrk@163.com> References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> <20251224161205.1132149-6-zhengxingda@iscas.ac.cn> <2183e580.8b98.19b5531263f.Coremail.andyshrk@163.com> <0eba66980024d001d4ff6d0aed6f2f3e356abf3a.camel@iscas.ac.cn> <5ce9d611.1868.19b5e9e7a61.Coremail.andyshrk@163.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:qwCowABX_mkeiU9p98L7AQ--.5607S2 X-Coremail-Antispam: 1UD129KBjvJXoWxXr1xGry7urWxJF1DuFyUWrg_yoW5Gw1rpF W8JFW3CryDJFn3Kw1I9w15JryYya1kJw4rWrnxJ3WIvr90kF10qr9rZFyYgFyDWr4fGr42 yr1UKrya9r1kJF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvmb7Iv0xC_Cr1lb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7 MxkF7I0En4kS14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnU UI43ZEXa7IU0uHq7UUUUU== X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2025-12-27=E6=98=9F=E6=9C=9F=E5=85=AD=E7=9A=84 15:03 +0800=EF=BC= =8CAndy Yan=E5=86=99=E9=81=93=EF=BC=9A >=20 >=20 > Hello=EF=BC=8C >=20 > =E5=9C=A8 2025-12-26 21:27:53=EF=BC=8C"Icenowy Zheng" =E5=86=99=E9=81=93=EF=BC=9A > > =E5=9C=A8 2025-12-25=E6=98=9F=E6=9C=9F=E5=9B=9B=E7=9A=84 19:07 +0800=EF= =BC=8CAndy Yan=E5=86=99=E9=81=93=EF=BC=9A > > >=20 > > >=20 > > > Hello Icenowy: > > >=20 > > > At 2025-12-25 00:12:01, "Icenowy Zheng" > > > wrote: > > > > From: Icenowy Zheng > > > >=20 > > > > T-Head TH1520 SoC contains a Synopsys DesignWare HDMI > > > > controller > > > > (paired > > > > with DesignWare HDMI TX PHY Gen2) that takes the "DP" output > > > > from > > > > the > > > > display controller. > > > >=20 > > > > Add a driver for this controller utilizing the common > > > > DesignWare > > > > HDMI > > > > code in the kernel. > > > >=20 > > > > Signed-off-by: Icenowy Zheng > > > > Signed-off-by: Icenowy Zheng > > > > --- > > > > No changes in v3, v4. > > > >=20 > > > > Changes in v2: > > > > - Created a new function to set PHY parameters and refactored > > > > the > > > > =C2=A0control flow of the configure_phy callback. > > > >=20 > > > > MAINTAINERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > > > > drivers/gpu/drm/bridge/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 10 ++ > > > > drivers/gpu/drm/bridge/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > > > > drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 173 > > > > ++++++++++++++++++++++++ > > > > 4 files changed, 185 insertions(+) > > > > create mode 100644 drivers/gpu/drm/bridge/th1520-dw-hdmi.c > > >=20 > > >=20 > > > As this is a Synopsys DesignWare based IP, maybe it's better to > > > put > > > it under=C2=A0=C2=A0 "drivers/gpu/drm/bridge/synopsys/" > > > Or just create a dir for thead, I think there will come other > > > display > > > related drivers for thead in the future. > >=20 > > It's not proper to place vendor glues to synopsys/ . >=20 >=20 > TI has precedents for doing this with Cadence IP=EF=BC=8C see=20 >=20 > drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c=20 Well for this kind of things, I prefer to hear from the maintainer of DW HDMI bridges (although it seems that this has no dedicated MAINTAINERS entry and get_maintainers just returns people for DRM DRIVERS FOR BRIDGE CHIPS). >=20 >=20 > >=20 > > As for T-Head, they stopped their embedded SoC business (sold to > > another company) and now they only makes data-center chips, there > > should be no T-Head display drivers in the future. > >=20 > > >=20 > > >=20 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 8< =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > >=20 > >=20 > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv