From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF997C43334 for ; Tue, 14 Jun 2022 07:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353309AbiFNHsQ (ORCPT ); Tue, 14 Jun 2022 03:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244775AbiFNHsN (ORCPT ); Tue, 14 Jun 2022 03:48:13 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 596BA3EA96 for ; Tue, 14 Jun 2022 00:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655192892; x=1686728892; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=JjBfmY6jMAFiAGXZ4FBSDiUOib4iBu1wkpXYBDiQX3I=; b=I4f9V9txCSW6WJy6YH9PkjEjUg/4p0vPyIr+UVdY4dC74/BXfjOYY4jX usIatDFlmbjrlzLhe3+OsFrsvtTs5qRDq6EyfRUDhm9R9BX7f21+MgGOm z70sD9DpfnhUpdnlKuzi9Wvu3K4A7vPVjhLRWvL2PI6hc5QhEUOQrTkhW xOOUvWTdMeM+Xw1glZckeu01/in5H7KFvfNBoe6WVrrvaP/w2El9Ya0kB KXSOKUwy7+vjPfVn08ySK1+5eEsAfyl6oKfl7cGmklGN2X0prcOwPNTQU d4q8D9aAgf06Na4IUVLtkXoVhRCdKRlayfhm0kAL9QrCAYUxCKeYh221+ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="364876959" X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="364876959" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 00:48:12 -0700 X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="910848920" Received: from gren5-mobl1.ccr.corp.intel.com (HELO [10.255.29.39]) ([10.255.29.39]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 00:48:10 -0700 Message-ID: <3b69098e-ec9c-42b1-24cb-c0b7052e1998@linux.intel.com> Date: Tue, 14 Jun 2022 15:48:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, "Liu, Yi L" , "Pan, Jacob jun" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] iommu/vt-d: Add set_dev_pasid callbacks for default domain Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , "Raj, Ashok" , Jason Gunthorpe References: <20220614034411.1634238-1-baolu.lu@linux.intel.com> <2d2a52db-70a8-788e-fedc-197789caa145@linux.intel.com> <3e2e6ee7-984f-254e-7a3e-e32d6256c8f2@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/14 15:19, Tian, Kevin wrote: >> From: Baolu Lu >> Sent: Tuesday, June 14, 2022 2:13 PM >> >> On 2022/6/14 13:36, Tian, Kevin wrote: >>>> From: Baolu Lu >>>> Sent: Tuesday, June 14, 2022 12:48 PM >>>> >>>> On 2022/6/14 12:02, Tian, Kevin wrote: >>>>>> From: Lu Baolu >>>>>> Sent: Tuesday, June 14, 2022 11:44 AM >>>>>> >>>>>> This allows the upper layers to set a domain to a PASID of a device >>>>>> if the PASID feature is supported by the IOMMU hardware. The typical >>>>>> use cases are, for example, kernel DMA with PASID and hardware >>>>>> assisted mediated device drivers. >>>>>> >>>>> why is it not part of the series for those use cases? There is no consumer >>>>> of added callbacks in this patch... >>>> It could be. I just wanted to maintain the integrity of Intel IOMMU >>>> driver implementation. >>> but let's not add dead code. and this patch is actually a right step >>> simply from set_dev_pasid() p.o.v hence you should include in any >>> series which first tries to use that interface. >>> >> >> Yes, that's my intention. If it reviews well, we can include it in the >> driver's implementation. >> > > Then you should make it clear in the first place. otherwise a patch > like this implies a review for merge. 😊 Yeah! Will update this in the next version. Best regards, baolu