From: "Christian Löhle" <CLoehle@hyperstone.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
John Keeping <john@metanate.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem
Date: Wed, 24 Nov 2021 12:52:48 +0000 [thread overview]
Message-ID: <3b78d0e4656f4df6bf548cd9f7557ec0@hyperstone.com> (raw)
In-Reply-To: <315972c2-2253-ad10-b712-2d2c96b3da26@samsung.com>
Sorry for hijacking this thread.
From: Jaehoon Chung <jh80.chung@samsung.com>
Sent: Wednesday, November 24, 2021 10:54 AM
To: Ulf Hansson; John Keeping
Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem
>>> The old "mshc" lookup is kept for backwards compatibility.
>>
>> The mshc alias is really weird!
>>
>> It looks like some leftover from when the dw_mmc controller supported
>> multiple slots. This support was dropped a long time ago, simply
>> because it never really worked - and it was not worth trying to. Only
>> one slot per controller is supported.
>
>As Ulf mentioned, dw_mmc controller can be supported multiple slot.
>But I didn't see its case to use multiple slot. And I had been done to drop a long time ago.
>
>mshc was used because of Mobile Storage Host Controller.
I assume this means you are open to a rework for dw_mmc?
I have a bigger patch for dw_mmc that I work on myself.
I removed the slot functionality at the start because there is no way for me to verify that I did not break this feature in the meantime.
But if it never worked and there is no platform for it, then removing this is fine for everyone?
Otherwise I probably would submit my rework for staging.
Regards,
Christian=
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz
Managing Director: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782
prev parent reply other threads:[~2021-11-24 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 19:02 [PATCH 0/2] mmc: dw_mmc: use standard "mmc" alias stem John Keeping
2021-11-16 19:02 ` [PATCH 1/2] mmc: dw_mmc: extract ctrl_id lookup to a function John Keeping
2021-11-16 19:02 ` [PATCH 2/2] mmc: dw_mmc: use standard "mmc" alias stem John Keeping
2021-11-23 19:34 ` Ulf Hansson
2021-11-24 9:54 ` Jaehoon Chung
2021-11-24 12:29 ` John Keeping
2021-11-24 15:13 ` Ulf Hansson
2021-11-24 12:52 ` Christian Löhle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b78d0e4656f4df6bf548cd9f7557ec0@hyperstone.com \
--to=cloehle@hyperstone.com \
--cc=jh80.chung@samsung.com \
--cc=john@metanate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox