From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751657AbdEVFJU (ORCPT ); Mon, 22 May 2017 01:09:20 -0400 Received: from mout.web.de ([212.227.15.14]:53120 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbdEVFJQ (ORCPT ); Mon, 22 May 2017 01:09:16 -0400 Subject: [PATCH 1/2] usbnet: Delete an error message for a failed memory allocation in usbnet_write_cmd_async() From: SF Markus Elfring To: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Oliver Neukum Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <3b831fce-93ed-c017-2549-967a39c2d1da@users.sourceforge.net> Date: Mon, 22 May 2017 07:09:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vZZ/WUYvfyV9eyY/ZpPKFbtYAa3DEFEvid6hhYwj2jhxRgKGi2d vQspSEDvoO3cmtxdIcWw5RyFveAXzeOFou32M1VOJU+IBKcXmV9qJPQEEdTl1XkaBLyEEiz tXhSvklgKJ0Wuot7P/lyIFoAPWdwxLgMvSGO1mBrCPtfjBuEPEBkwXT4rLaAxOAMcFEGR5h 5Ok9fUiCqOifGiaLXdzBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:RWs1qmYig/8=:VfI2eZ1WtQUacS+5hlpF+M /qglpziYc8YnsKYs8CeK+UGR5pZ5ag9YV+BSunJfAGCvpjZ4epOr7yecO4KkJoaQxEYWnc9XH HBaNun537Y86eEU8gu1H4WPXWbUXJpHvpzy028ZOP8pENYgo0fdRZYTTC4AMMSCYOgrr0jr6+ wY47w/B1+54PnlriT5STTHaYpfJYn+LItxdz+tfoBf1ExY18i4FHdzcoQu1ZSM802L1XIqqBC AlDZsYcFQrnMmb04Nu15xyIBLoMxTxT8j8r2SDVO6v21ijw5LrDNXzvCqwCYCsglHqd1rf8a8 9NZB0/RUAQNVeuhKWFM1fhUa5KrNGk+L0/tbOZJ82LJhrkPSrRbxMsH3771Tvbp1yyibICfYk /uKSrDkoPUPCM3oo+4N/kJ7Y11tYYBHhZBK2gciovFz5tnczT0TRsZjhutZ0U67jQdKvl+dwI kmfZFvKb8Psu5U3rOq6epaIK6h/KUtKI4ZaWULVIaD+fcGCbZx4siAceKm5t3BpgdxrppBqVF BA/U91s4TjPzleQdVhzYGtWonJbecFFrrXf5Jz2S8/eD3+cvIbmVH63DLt0Vk19tGj/rb1ISR eaL+8MsHkidfKQOuN7ZH94s0UPIOmuqIVEd1fnUgQiP2tzp5wG28oGFPiMas4TtPqiJ77n/2k tzQ6A/rwHIFIRiJAtv1ckKE+xH8s/StuqoAtvgYpAfM5ZRuZMVMzqKjRzdupywTsB319GBi+i QDWkm/VyEkDDnRfsykBG2UDYF1XRKlyTOS6taTOPreRVS1USn4jcQhaYiXPwO1InhGwkqFRIX ywQdmGf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 22 May 2017 06:33:48 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/net/usb/usbnet.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 79048e72c1bd..802ba68d37d1 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -2124,10 +2124,7 @@ int usbnet_write_cmd_async(struct usbnet *dev, u8 cmd, u8 reqtype, if (data) { buf = kmemdup(data, size, GFP_ATOMIC); - if (!buf) { - netdev_err(dev->net, "Error allocating buffer" - " in %s!\n", __func__); + if (!buf) goto fail_free; - } } -- 2.13.0