From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F01B14A60C for ; Thu, 4 Sep 2025 05:30:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756963856; cv=none; b=D0n/2q7VkXK2dK9OR+2b/GM9GCMgRCHc588DVOz6RHaYB4rw+u/k7TkxtfH2ba7CvBc9VkIOLG+WBRXd3EoB5FX/QOdxMUofHgtTS9bMIOba9tzh+R70NqWvna6CTzvHA3PPdeJoGIRTX8xzqH7C5LC3rqoH2X8rNs7+gSQKn4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756963856; c=relaxed/simple; bh=QbtysNsVS2fD+bIGwCcBf0x7URUoQDF5HoZ72mIJ+r8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bBhZ+Z2/tpZR+wDWXhk/pLehA5JI9035vlunR3H5DdLdLAkb/a1KJE7rEaE0SjP/S6BdKcTOPv+pRbtYw1I3VxQm76fdB8sHc5Dl+ack0QTAf/6UoYgSeHw86YxAVQsiFMw5xdEUxiQ5XJGDk7dedhjpWVUDW5p/ED2mGYz8Pvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eVd2RIGB; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eVd2RIGB" Message-ID: <3b86ceb7-5dd4-4531-83cb-4b0229caae97@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756963843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QbtysNsVS2fD+bIGwCcBf0x7URUoQDF5HoZ72mIJ+r8=; b=eVd2RIGBDJEqSGK3foxgaEsefELGup0McpeOxqMLEq8zE0kMF8LW1sewIM34PXqFyR2UWZ Y8Z0imChzysfJSH3d01WAbvg95txXcCA/P4kYki9h54T6YTdOpUJ9SyiXKsrV5zjTmkdyj m4KAJil8Ahm/OUmmTAeEqU+X2/HlRMw= Date: Wed, 3 Sep 2025 22:30:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v1] libbpf: remove unused args in parse_usdt_note Content-Language: en-GB To: Jiawei Zhao , ast@kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250904030525.1932293-1-phoenix500526@163.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20250904030525.1932293-1-phoenix500526@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/3/25 8:05 PM, Jiawei Zhao wrote: > Remove unused 'elf' and 'path' parameters from parse_usdt_note function > signature. These parameters are not referenced within the function body > and only add unnecessary complexity. > > The function only requires the note header, data buffer, offsets, and > output structure to perform USDT note parsing. > > Update function declaration, definition, and the single call site in > collect_usdt_targets() to match the simplified signature. > > This is a safe internal cleanup as parse_usdt_note is a static function. > > Signed-off-by: Jiawei Zhao Acked-by: Yonghong Song