From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DECC83F17 for ; Sat, 26 Aug 2023 08:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbjHZIK7 (ORCPT ); Sat, 26 Aug 2023 04:10:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbjHZIKp (ORCPT ); Sat, 26 Aug 2023 04:10:45 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AE2719A2; Sat, 26 Aug 2023 01:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693037443; x=1724573443; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=jlu0jGsz3YUaNHKDYc4hDn69ED5yf7AXMnsAeLD1XTY=; b=b+ck2E9Gst/4kpB/ME68nFsnM/itHxTR6KakSeqhLS6Ly8Lzeyj6QD89 KueAwGgz903ExrpCJV/sg/rH1dlhe+qWpHv8PCeMTGn68PSWFzX/D77YO zxzYtXm73Px0+ybBT8WXxWht0AygXX4DtPqovsKPdtBQaqVPO1RIqd0qz yN6pmd8kGdAq3e65b0RyUvJK4+PAjwgRKXF0K7S10JUFPZ+5wTkwG7wHW bYWzqzFYHXMJdUJ9WKjZgYsrsUPOSOJjsSu7uWSoLXCTyzpmCjlm5/3gO t0KSDd5wWBG7ED+QpAao87Nx5uFkFhjuQZel61d78xsFh3isiDZ9M2BVR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="405853122" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="405853122" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2023 01:10:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="772735780" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="772735780" Received: from allen-box.sh.intel.com (HELO [10.239.159.127]) ([10.239.159.127]) by orsmga001.jf.intel.com with ESMTP; 26 Aug 2023 01:10:39 -0700 Message-ID: <3b893bf4-a566-9a1f-49da-17efdd7e4661@linux.intel.com> Date: Sat, 26 Aug 2023 16:08:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: baolu.lu@linux.intel.com, "Liu, Yi L" , Jacob Pan , "iommu@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 09/10] iommu: Make iommu_queue_iopf() more generic Content-Language: en-US To: "Tian, Kevin" , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Jean-Philippe Brucker , Nicolin Chen References: <20230825023026.132919-1-baolu.lu@linux.intel.com> <20230825023026.132919-10-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/25/23 4:17 PM, Tian, Kevin wrote: >> + >> + list_for_each_entry(iopf, &iopf_param->faults, list) { >> + if (WARN_ON(iopf->fault.prm.pasid == pasid)) >> + break; >> + } >> + mutex_unlock(&iopf_param->lock); >> +} >> + >> void iommu_detach_device(struct iommu_domain *domain, struct device >> *dev) >> { >> struct iommu_group *group; >> @@ -1959,6 +1980,7 @@ void iommu_detach_device(struct iommu_domain >> *domain, struct device *dev) >> if (!group) >> return; >> >> + assert_no_pending_iopf(dev, IOMMU_NO_PASID); >> mutex_lock(&group->mutex); >> if (WARN_ON(domain != group->domain) || >> WARN_ON(list_count_nodes(&group->devices) != 1)) >> @@ -3269,6 +3291,7 @@ void iommu_detach_device_pasid(struct >> iommu_domain *domain, struct device *dev, >> { >> struct iommu_group *group = iommu_group_get(dev); >> >> + assert_no_pending_iopf(dev, pasid); > this doesn't look correct. A sane driver will stop triggering new > page request before calling detach but there are still pending ones > not drained until iopf_queue_flush_dev() called by > ops->remove_dev_pasid(). > > then this check will cause false warning. > You are right. It is not only incorrect but also pointless. The iommu driver should flush the iopf queues in the path of detaching domains. I will remove it if no objection. Best regards, baolu