From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D1320C038 for ; Wed, 14 May 2025 08:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747212037; cv=none; b=Z1kkb7bixn6g0YwhDGDydPlLyn9YKF/sSJjn7FD/nlaQM5DyLNxlvwMoGhBhUtxxOXoC0WWeBFwX0FzBjHlz2D58s+Tqubf/7kk4js3VgbZwe7laISa5plcUCKZU20FQlMOHUp07LsYzskce0qvLECd98/AMXZWzGuSgb9uwfDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747212037; c=relaxed/simple; bh=bOvlpJgB38yWtB6iHmH6Tk5IzM3ygnlwVf/ZOxmrdgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aIA3A5AF773E9Drx4sJ64pqNsJXOWlk4w7PrKjtQGeSPq6TiZpJIANQ4Txfl06s0/r85qngxMmE5a8dQA8HVIJp8H24E/GsXRlXyQWbRMViRpN19Oibyvlbrc3qkV+MURyxJPsiUN5biokBvEFl00v/0qalaIlwB/ZaXH6P6zcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ZDmZZybQ; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ZDmZZybQ" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a1f5d2d91eso3751299f8f.1 for ; Wed, 14 May 2025 01:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1747212034; x=1747816834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XUZ+TWBCEumVyKUR1t0gEvLsedm10yxyAulY/94k4bA=; b=ZDmZZybQav+Ly9/LFyPILWry6DnnrY7Uj2P8/t3fZ/8N6MlvjwPOq8ochp2fYz5Xjf dgWsby0IOuX+FJsM9VGytDmIRBtmPx+lpjgqFDOdam3M9q1L+onH3PauIvfnHSpBJ6LX p0EBhBcBNdj3QoGi76bdIVf+Hh6vTLUG2tcLdMaeG0J5P855WrBo1AplITse9EmmDWnq X2eert3ic6eWEpMyTC1vXimz+wpJWgBq7kB9HYrB/f/1OXBwEV1ul3Hdt/XvvEk96r3v NQwPJcj00AtxHQF4by7aLMCaTG1GPtyylCvykwd6bg+Z2AOyM6HNVtE6MfkjGF5/8ETs Jd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747212034; x=1747816834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XUZ+TWBCEumVyKUR1t0gEvLsedm10yxyAulY/94k4bA=; b=dGZWDv2H+j449y/PLHMXWGuUfSably8xjwcaFSX2JRhiE8HzH8E52S3OQog+ZE0i2F UIC+k735bOzzSrMtOlxyMv3MGkgdvwvxkq4YFEkMChn09sbNX7gHPxxJvPeHbZ8iqKfv iPQ8Oah+DtMp0hNvqF3LsKnDt2Iw/1eVjKqkfd0y4TCYCD8AAskb2cCSWHGa/Rfzd/Ai XocJ1Zvl2a7J0TizaW2jnSbfGxC04+iSftMgM6aOV7Rz73dQbpBInI9fG9HBkukifn1J VQ97aU8ieNHHa+wY/iVvems1T6U6W/1SP1DKRQGlvS7kPVNzCL7AIkUa0/hn9ZQNe+Vn douA== X-Forwarded-Encrypted: i=1; AJvYcCUtvwRN00kjArg6EjsyNwhm8RiIp2exhdzxh/nA+HeFlVQ2hdkRte9fMvv1Jp0ZAg1pkauidw8WvjWQsH4=@vger.kernel.org X-Gm-Message-State: AOJu0YzNCkLIAFn8viULeHGIO7nXhXgKFjimS8eOWTXiVGb4dyJTHrl+ kFTjqQXNQp44VNqH9DKbmMuot+GwYHYFguWTDzUXtnSkk4okhq9Xp213wqFe5TY= X-Gm-Gg: ASbGncvXgItERXUDgMxmLR9Qmt8EKMqaNPy0+QSkuWdq7tSRV8LkeTYToXtadb5kHXy ECg9lWouCd5ZYcM5iRJ10hJ0JFN2Mi2DsuGDtzk03hw3B5V8hkc/AhxfQmcClRonIFSMSzD4VXW 5ar2WkfvT1LMep7rDfKro3GeAzLhpjhghuBGIK8fq36eaYH9VQ/p7XEFENl6S8cKoU5ZbBAgdgg +1OSOnlnULZDtGRIpNOnvC0JBieH4hLTomxZaL47DEW7MDpiM3hZ/lNroPx/2BvQHNoSi08YLp3 zrcbkjOIa3EIuDCC8hBRwxeJKmddopziPxdGmpuetIrQkrcmjJTVxg== X-Google-Smtp-Source: AGHT+IFF2gEltVWksw/7sMuSeu0VYvts2lcQdv0P/daOYEJ1wwTuGxfg8BHv9/A6qpkaqat5IeIqJg== X-Received: by 2002:a05:6000:4284:b0:3a0:7f85:1905 with SMTP id ffacd0b85a97d-3a3493dada6mr2246544f8f.0.1747212034024; Wed, 14 May 2025 01:40:34 -0700 (PDT) Received: from [10.100.51.48] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4dea857f729sm7994896137.1.2025.05.14.01.40.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 01:40:33 -0700 (PDT) Message-ID: <3b8dad35-5af2-41f3-aea2-07db9761dd4a@suse.com> Date: Wed, 14 May 2025 10:40:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper To: Peter Zijlstra Cc: mcgrof@kernel.org, x86@kernel.org, hpa@zytor.com, samitolvanen@google.com, da.gomez@samsung.com, masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, hch@infradead.org, gregkh@linuxfoundation.org, roypat@amazon.co.uk References: <20250502141204.500293812@infradead.org> <20250502141844.369838967@infradead.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250502141844.369838967@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/2/25 16:12, Peter Zijlstra wrote: > Helper macro to more easily limit the export of a symbol to a given > list of modules. > > Eg: > > EXPORT_SYMBOL_GPL_FOR_MODULES(preempt_notifier_inc, "kvm"); > > will limit the use of said function to kvm.ko, any other module trying > to use this symbol will refure to load (and get modpost build > failures). > > Requested-by: Masahiro Yamada > Requested-by: Christoph Hellwig > Signed-off-by: Peter Zijlstra (Intel) > --- > [...] > --- a/include/linux/export.h > +++ b/include/linux/export.h > @@ -24,11 +24,17 @@ > .long sym > #endif > > -#define ___EXPORT_SYMBOL(sym, license, ns) \ > +/* > + * LLVM integrated assembler cam merge adjacent string literals (like > + * C and GNU-as) passed to '.ascii', but not to '.asciz' and chokes on: > + * > + * .asciz "MODULE_" "kvm" ; > + */ Typo: "cam" -> "can't". I can correct it when picking up the series. Reviewed-by: Petr Pavlu -- Petr > +#define ___EXPORT_SYMBOL(sym, license, ns...) \ > .section ".export_symbol","a" ASM_NL \ > __export_symbol_##sym: ASM_NL \ > .asciz license ASM_NL \ > - .asciz ns ASM_NL \ > + .ascii ns "\0" ASM_NL \ > __EXPORT_SYMBOL_REF(sym) ASM_NL \ > .previous > > @@ -85,4 +91,6 @@ > #define EXPORT_SYMBOL_NS(sym, ns) __EXPORT_SYMBOL(sym, "", ns) > #define EXPORT_SYMBOL_NS_GPL(sym, ns) __EXPORT_SYMBOL(sym, "GPL", ns) > > +#define EXPORT_SYMBOL_GPL_FOR_MODULES(sym, mods) __EXPORT_SYMBOL(sym, "GPL", "module:" mods) > + > #endif /* _LINUX_EXPORT_H */ > >