From: "Arnd Bergmann" <arnd@arndb.de>
To: "Yan, Dongcheng" <dongcheng.yan@intel.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Cc: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
"laurent.pinchart" <laurent.pinchart@ideasonboard.com>,
"Umang Jain" <umang.jain@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies:
Date: Mon, 17 Mar 2025 11:32:13 +0100 [thread overview]
Message-ID: <3bb730a9-5d8a-41c6-8a27-e099561b5890@app.fastmail.com> (raw)
In-Reply-To: <ecb959fe-69e3-4265-9e4b-326bff421153@intel.com>
On Mon, Mar 17, 2025, at 11:17, Yan, Dongcheng wrote:
> On 3/14/2025 11:46 PM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> @@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
>>
>> config VIDEO_LT6911UXE
>> tristate "Lontium LT6911UXE decoder"
>> - depends on ACPI && VIDEO_DEV
>> + depends on ACPI && VIDEO_DEV && I2C
>> select V4L2_FWNODE
>> + select V4L2_CCI_I2C
>> help
>> This is a Video4Linux2 sensor-level driver for the Lontium
>> LT6911UXE HDMI to MIPI CSI-2 bridge.
>
> Thanks for your fix.
>
> Lkp is a bit weird to me, because it tested a warning in patch v6 likes
> below:
>
> kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
> when selected by VIDEO_LT6911UXE
What was the full warning? The only dependency I see in V4L2_CCI_I2C
is CONFIG_I2C itself, and that is what I add above.
> So I remove this select flag and passed lkp build test in patch v7.
> But now it encounters build error again, I'm curious why...
I don't currently get any more build errors with my patch
added in, and I think this should be sufficient. Can you forward
me the errors and config you get with my patch?
Arnd
next prev parent reply other threads:[~2025-03-17 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 15:46 [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies: Arnd Bergmann
2025-03-17 10:17 ` Yan, Dongcheng
2025-03-17 10:32 ` Arnd Bergmann [this message]
2025-03-18 13:51 ` Hans Verkuil
2025-04-30 11:21 ` Arnd Bergmann
2025-04-30 12:14 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb730a9-5d8a-41c6-8a27-e099561b5890@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox