Re: [PATCH] x86/xen: fix xen_hypercall_hvm() to not clobber %rbx

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1086 bytes --]

On 05.02.25 10:16, Andrew Cooper wrote:
> On 05/02/2025 9:10 am, Juergen Gross wrote:
>> xen_hypercall_hvm(), which is used when running as a Xen PVH guest at
>> most only once during early boot, is clobbering %rbx. Depending on
>> whether the caller relies on %rbx to be preserved across the call or
>> not, this clobbering might result in an early crash of the system.
>>
>> This can be avoided by not modifying %rbx in xen_hypercall_hvm().
>>
>> Fixes: b4845bb63838 ("x86/xen: add central hypercall functions")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>   arch/x86/xen/xen-head.S | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
>> index 9252652afe59..4378b817ed32 100644
>> --- a/arch/x86/xen/xen-head.S
>> +++ b/arch/x86/xen/xen-head.S
>> @@ -117,8 +117,7 @@ SYM_FUNC_START(xen_hypercall_hvm)
> 
> The 32bit case, out of context up here, also clobbers %ebx.
> 
> ~Andrew
> 
>>   	pop %ebx

It does not, as this part of the context is showing.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]