Re: [PATCH v3 09/16] platform/x86: x86-android-tablets: Add include defining struct dmi_system_id

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]

On Sun, 28 Jun 2026, Uwe Kleine-König (The Capable Hub) wrote:

> Currently <linux/i2c.h> includes <linux/mod_devicetable.h> transitively
> which ensures that struct dmi_system_id is defined in
> drivers/platform/x86/x86-android-tablets/x86-android-tablets.h. However
> this include in <linux/i2c.h> will be replaced by one for i2c_device_id
> only. To ensure that dmi_system_id is available add the include for that
> explicitly.
> 
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
>  drivers/platform/x86/x86-android-tablets/x86-android-tablets.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
> index 2498390958ad..c756961ae5fd 100644
> --- a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
> +++ b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h
> @@ -13,6 +13,7 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/i2c.h>
>  #include <linux/irqdomain_defs.h>
> +#include <linux/device-id/dmi.h>
>  #include <linux/spi/spi.h>
>  
>  struct gpio_desc;

Indirect include patchs are never a good idea as it always makes header 
reorganizations minefield. So for this change,

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


When it comes to the series, I certainly like the direction it goes very 
much (never have been fan of mod_devicetable.h) but I'd have preferred 
stepwise approach over trying to introduce it to some mid-rc.

-- 
 i.