From: Shuah Khan <skhan@linuxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Stafford Horne <shorne@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Shuah Khan <shuah@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm
Date: Mon, 13 Jan 2025 15:59:24 -0700 [thread overview]
Message-ID: <3bcdf139-81e2-4ef3-8e86-1e22b4df6d49@linuxfoundation.org> (raw)
In-Reply-To: <44f202e8-dc35-40aa-8dc3-2f2e4c28feda@efficios.com>
On 1/10/25 09:22, Mathieu Desnoyers wrote:
> On 2025-01-02 23:03, Stafford Horne wrote:
>> When working on OpenRISC support for restartable sequences I noticed
>> and fixed these two issues with the riscv support bits.
>>
>> 1 The 'inc' argument to RSEQ_ASM_OP_R_DEREF_ADDV was being implicitly
>> passed to the macro. Fix this by adding 'inc' to the list of macro
>> arguments.
>> 2 The inline asm input constraints for 'inc' and 'off' use "er", The
>> riscv gcc port does not have an "e" constraint, this looks to be
>> copied from the x86 port. Fix this by just using an "r" constraint.
>>
>> I have compile tested this only for riscv. However, the same fixes I
>> use in the OpenRISC rseq selftests and everything passes with no issues.
>>
>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>
> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>
If these are going through risc repo
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
If you would like me to take this, let me know.
thanks,
-- Shuah
next prev parent reply other threads:[~2025-01-13 22:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 4:03 [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm Stafford Horne
2025-01-10 2:29 ` Charlie Jenkins
2025-01-10 9:56 ` Stafford Horne
2025-01-10 16:22 ` Mathieu Desnoyers
2025-01-13 22:59 ` Shuah Khan [this message]
2025-01-14 17:04 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bcdf139-81e2-4ef3-8e86-1e22b4df6d49@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shorne@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox