From: "Singh, Balbir" <sblbir@amazon.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "hch@lst.de" <hch@lst.de>,
"Chaitanya.Kulkarni@wdc.com" <Chaitanya.Kulkarni@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [PATCH v2 0/5] Add support for block disk resize notification
Date: Thu, 12 Mar 2020 22:51:45 +0000 [thread overview]
Message-ID: <3c43712ebbd3d4e5c301677a17ec7a301487faa4.camel@amazon.com> (raw)
In-Reply-To: <05bb1606-4cf1-dba3-22a0-5f8624b43767@kernel.dk>
On Thu, 2020-03-12 at 08:06 -0600, Jens Axboe wrote:
>
> On 3/2/20 9:03 PM, Singh, Balbir wrote:
> > On Tue, 2020-02-25 at 20:01 +0000, Balbir Singh wrote:
> > > Allow block/genhd to notify user space about disk size changes using a
> > > new helper set_capacity_revalidate_and_notify(), which is a wrapper
> > > on top of set_capacity(). set_capacity_revalidate_and_notify() will only
> > > notify
> > > iff the current capacity or the target capacity is not zero and the
> > > capacity really changes.
> > >
> > > Background:
> > >
> > > As a part of a patch to allow sending the RESIZE event on disk capacity
> > > change, Christoph (hch@lst.de) requested that the patch be made generic
> > > and the hacks for virtio block and xen block devices be removed and
> > > merged via a generic helper.
> > >
> > > This series consists of 5 changes. The first one adds the basic
> > > support for changing the size and notifying. The follow up patches
> > > are per block subsystem changes. Other block drivers can add their
> > > changes as necessary on top of this series. Since not all devices
> > > are resizable, the default was to add a new API and let users
> > > slowly convert over as needed.
> > >
> > > Testing:
> > > 1. I did some basic testing with an NVME device, by resizing it in
> > > the backend and ensured that udevd received the event.
> > >
> > >
> > > Changelog v2:
> > > - Rename disk_set_capacity to set_capacity_revalidate_and_notify
> > > - set_capacity_revalidate_and_notify can call revalidate disk
> > > if needed, a new bool parameter is passed (suggested by Bob Liu)
> > >
> >
> > Ping? It's not an urgent patchset, I am happy to wait if nothing else is
> > needed.
>
> It doesn't apply to the 5.7 branches, can you resend against for-5.7/block?
>
Thanks, I'll take a look. I used the latest next (next-20200312) and rebased
on it. I got a three way merge success on xen-blkfront
Using index info to reconstruct a base tree...
M drivers/block/xen-blkfront.c
Falling back to patching base and 3-way merge...
I presume you are running into the same thing.
I will resend the patches on top of next shortly
Balbir
prev parent reply other threads:[~2020-03-12 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:01 [PATCH v2 0/5] Add support for block disk resize notification Balbir Singh
2020-02-25 20:01 ` [PATCH v2 1/5] block/genhd: Notify udev about capacity change Balbir Singh
2020-02-25 20:01 ` [PATCH v2 2/5] drivers/block/virtio_blk.c: Convert to use set_capacity_revalidate_and_notify Balbir Singh
2020-02-25 20:01 ` [PATCH v2 3/5] drivers/block/xen-blkfront.c: " Balbir Singh
2020-02-25 20:01 ` [PATCH v2 4/5] drivers/nvme/host/core.c: " Balbir Singh
2020-02-25 20:24 ` Sagi Grimberg
2020-02-26 18:08 ` Keith Busch
2020-02-27 22:31 ` Singh, Balbir
2020-02-25 20:01 ` [PATCH v2 5/5] drivers/scsi/sd.c: " Balbir Singh
2020-03-03 4:03 ` [PATCH v2 0/5] Add support for block disk resize notification Singh, Balbir
2020-03-12 14:06 ` Jens Axboe
2020-03-12 22:51 ` Singh, Balbir [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c43712ebbd3d4e5c301677a17ec7a301487faa4.camel@amazon.com \
--to=sblbir@amazon.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox