From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754544AbdEGVuy (ORCPT <rfc822;w@1wt.eu>);
        Sun, 7 May 2017 17:50:54 -0400
Received: from mail-pg0-f45.google.com ([74.125.83.45]:33509 "EHLO
        mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752954AbdEGVuw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 7 May 2017 17:50:52 -0400
Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
References: <CA+55aFyfuSPCJob5EPBRux+VwtTDBXhc3ijtB0sVtNCqBe5xPg@mail.gmail.com>
 <20170507171252.5149-1-ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Dave Airlie <airlied@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk>
Date: Sun, 7 May 2017 11:46:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170507171252.5149-1-ville.syrjala@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add a new Kconfig option to enable/disable the extra warnings
> from the vblank evade code. For now we'll keep the warning
> about an actually missed vblank always enabled as that can have
> an actual user visible impact. But if we miss the deadline
> othrwise there's no real need to bother the user with that.
> We'll want these warnings enabled during development however
> so that we can catch regressions.
> 
> Based on the reports it looks like this is still very easy
> to hit on SKL, so we have more work ahead of us to optimize
> the crtiical section further.

Shouldn't it just be a debug printk or something instead, so that normal
people don't see it, but the folks that turn on debugging can get the
info they need? Seems silly to add a kconfig option for this.

-- 
Jens Axboe