* [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies
@ 2023-11-07 6:45 Jagadeesh Kona
2023-11-07 11:18 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jagadeesh Kona @ 2023-11-07 6:45 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Bjorn Andersson
Cc: Jagadeesh Kona, Taniya Das, Dmitry Baryshkov, linux-arm-msm,
linux-clk, linux-kernel, Ajit Pandey, Imran Shaik, Randy Dunlap,
kernel test robot
SM_GCC_8550 depends on ARM64 but it is selected by
SM_CAMCC_8550, which should have the same dependencies
as SM_GCC_8550 to avoid the below Kconfig warning reported
by kernel test robot.
WARNING: unmet direct dependencies detected for SM_GCC_8550
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_CAMCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
Fixes: ccc4e6a061a2 ("clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311062309.XugQH7AH-lkp@intel.com/
Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
---
drivers/clk/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index ad1acd9b7426..dbc3950c5960 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -767,6 +767,7 @@ config SM_CAMCC_8450
config SM_CAMCC_8550
tristate "SM8550 Camera Clock Controller"
+ depends on ARM64 || COMPILE_TEST
select SM_GCC_8550
help
Support for the camera clock controller on SM8550 devices.
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies
2023-11-07 6:45 [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies Jagadeesh Kona
@ 2023-11-07 11:18 ` Dmitry Baryshkov
2023-11-07 15:57 ` Randy Dunlap
2023-11-27 23:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-11-07 11:18 UTC (permalink / raw)
To: Jagadeesh Kona
Cc: Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Bjorn Andersson, Taniya Das, linux-arm-msm, linux-clk,
linux-kernel, Ajit Pandey, Imran Shaik, Randy Dunlap,
kernel test robot
On Tue, 7 Nov 2023 at 08:46, Jagadeesh Kona <quic_jkona@quicinc.com> wrote:
>
> SM_GCC_8550 depends on ARM64 but it is selected by
> SM_CAMCC_8550, which should have the same dependencies
> as SM_GCC_8550 to avoid the below Kconfig warning reported
> by kernel test robot.
>
> WARNING: unmet direct dependencies detected for SM_GCC_8550
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
> Selected by [y]:
> - SM_CAMCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
>
> Fixes: ccc4e6a061a2 ("clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311062309.XugQH7AH-lkp@intel.com/
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index ad1acd9b7426..dbc3950c5960 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -767,6 +767,7 @@ config SM_CAMCC_8450
>
> config SM_CAMCC_8550
> tristate "SM8550 Camera Clock Controller"
> + depends on ARM64 || COMPILE_TEST
> select SM_GCC_8550
> help
> Support for the camera clock controller on SM8550 devices.
> --
> 2.41.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies
2023-11-07 6:45 [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies Jagadeesh Kona
2023-11-07 11:18 ` Dmitry Baryshkov
@ 2023-11-07 15:57 ` Randy Dunlap
2023-11-27 23:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-11-07 15:57 UTC (permalink / raw)
To: Jagadeesh Kona, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Bjorn Andersson
Cc: Taniya Das, Dmitry Baryshkov, linux-arm-msm, linux-clk,
linux-kernel, Ajit Pandey, Imran Shaik, kernel test robot
On 11/6/23 22:45, Jagadeesh Kona wrote:
> SM_GCC_8550 depends on ARM64 but it is selected by
> SM_CAMCC_8550, which should have the same dependencies
> as SM_GCC_8550 to avoid the below Kconfig warning reported
> by kernel test robot.
>
> WARNING: unmet direct dependencies detected for SM_GCC_8550
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
> Selected by [y]:
> - SM_CAMCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
>
> Fixes: ccc4e6a061a2 ("clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311062309.XugQH7AH-lkp@intel.com/
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index ad1acd9b7426..dbc3950c5960 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -767,6 +767,7 @@ config SM_CAMCC_8450
>
> config SM_CAMCC_8550
> tristate "SM8550 Camera Clock Controller"
> + depends on ARM64 || COMPILE_TEST
> select SM_GCC_8550
> help
> Support for the camera clock controller on SM8550 devices.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies
2023-11-07 6:45 [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies Jagadeesh Kona
2023-11-07 11:18 ` Dmitry Baryshkov
2023-11-07 15:57 ` Randy Dunlap
@ 2023-11-27 23:45 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2023-11-27 23:45 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Jagadeesh Kona, Konrad Dybcio,
Michael Turquette
Cc: Jagadeesh Kona, Taniya Das, Dmitry Baryshkov, linux-arm-msm,
linux-clk, linux-kernel, Ajit Pandey, Imran Shaik, Randy Dunlap,
kernel test robot
Quoting Jagadeesh Kona (2023-11-06 22:45:45)
> SM_GCC_8550 depends on ARM64 but it is selected by
> SM_CAMCC_8550, which should have the same dependencies
> as SM_GCC_8550 to avoid the below Kconfig warning reported
> by kernel test robot.
>
> WARNING: unmet direct dependencies detected for SM_GCC_8550
> Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
> Selected by [y]:
> - SM_CAMCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
>
> Fixes: ccc4e6a061a2 ("clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311062309.XugQH7AH-lkp@intel.com/
> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-27 23:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 6:45 [PATCH] clk: qcom: Fix SM_CAMCC_8550 dependencies Jagadeesh Kona
2023-11-07 11:18 ` Dmitry Baryshkov
2023-11-07 15:57 ` Randy Dunlap
2023-11-27 23:45 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).