From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 221BB2C324F; Wed, 5 Nov 2025 09:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762334910; cv=none; b=hcjYjURctbAPS9rJeYvEOuF8shD8JhqTSYpFynZvKxi4BziIKEyDFhLI4WDT2ijOjTwDDDo7RpV/ariU6dMecnNX6aDfvMWvoKugJx5A61OheinOVqJvG5/V6hABY8ZLngzeI6Lmz540whXC8cMUybkbxXkYDMRB8wwktxRkZ4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762334910; c=relaxed/simple; bh=UuoXHqgYudgzf/qPfLN6fBOeF8Pt0vTEw+WX56Wkuss=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iQ7kgWUtUuHgfLjFE1wcnAKTD8N6ItvyUG2LUobFEqTmMFPFajA91/vhXqCt0u+WxHgKPO4by++NWYfZw2J+jKAzqQDShFGD+NcsOsTrIDGnjPRlnBS1dP/unMrfXMRdwKA7JkPFk9o2WsasHXubDjxcc83leXuSiTYNrrZKYYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gr5YfO4C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gr5YfO4C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 844B4C4CEF8; Wed, 5 Nov 2025 09:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762334909; bh=UuoXHqgYudgzf/qPfLN6fBOeF8Pt0vTEw+WX56Wkuss=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gr5YfO4CInsfjgysY7nG/cjPkURzyoev2XPmebSvpxDXSib2pebYMdRw1vLdeTw62 bIxqv/5XoeQDWSUvD4fyQ/KbYNGCaPKFmiq5gGH6Ym/2N7Z1YJ7Y102mrBuut/V8N7 g99fGVYPN6qut/M2s/bIg2mTvuCN2DWYtQXXxUEInqMi50oOSPobMMWPShgKiGDuk1 tu5q5x5SN4sRnKXTlBB1Wbz0jPRfilxvvkSepovv3XjrI3pg/cS1Fk7w+TVk/EVz4o HiGOZ07Oj58Ovo1VcIr0DJWt9nzifN5qjU4bA+x2YqXjjqnPgeRdlRIg1tHE8vEp4a cKPi41GVh9b3w== Message-ID: <3c5a4d02-7391-48ec-bd45-d2ccacca1df6@kernel.org> Date: Wed, 5 Nov 2025 10:28:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/1] cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM To: Konrad Dybcio , Christian Marangi , Ilia Lin , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Baryshkov References: <20251104140635.25965-1-ansuelsmth@gmail.com> <20251104140635.25965-2-ansuelsmth@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/11/2025 10:12, Konrad Dybcio wrote: > On 11/5/25 9:05 AM, Krzysztof Kozlowski wrote: >> On 04/11/2025 15:06, Christian Marangi wrote: >>> On some IPQ806x SoC SMEM might be not initialized by SBL. This is the >>> case for some Google devices (the OnHub family) that can't make use of >>> SMEM to detect the SoC ID. >>> >>> To handle these specific case, check if the SMEM is not initialized (by >>> checking if the qcom_smem_get_soc_id returns -ENODEV) and fallback to >>> OF machine compatible checking to identify the SoC variant. >>> >>> Suggested-by: Dmitry Baryshkov >>> Signed-off-by: Christian Marangi >>> --- >>> drivers/cpufreq/qcom-cpufreq-nvmem.c | 35 ++++++++++++++++++++++++++-- >>> 1 file changed, 33 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c >>> index 3a8ed723a23e..17c79955ff2f 100644 >>> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c >>> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c >>> @@ -252,13 +252,22 @@ static int qcom_cpufreq_krait_name_version(struct device *cpu_dev, >>> return ret; >>> } >>> >>> +static const struct of_device_id qcom_cpufreq_ipq806x_match_list[] = { >>> + { .compatible = "qcom,ipq8062", .data = (const void *)QCOM_ID_IPQ8062 }, >>> + { .compatible = "qcom,ipq8064", .data = (const void *)QCOM_ID_IPQ8064 }, >>> + { .compatible = "qcom,ipq8065", .data = (const void *)QCOM_ID_IPQ8065 }, >>> + { .compatible = "qcom,ipq8066", .data = (const void *)QCOM_ID_IPQ8066 }, >>> + { .compatible = "qcom,ipq8068", .data = (const void *)QCOM_ID_IPQ8068 }, >>> + { .compatible = "qcom,ipq8069", .data = (const void *)QCOM_ID_IPQ8069 }, >>> +}; >>> + >>> static int qcom_cpufreq_ipq8064_name_version(struct device *cpu_dev, >>> struct nvmem_cell *speedbin_nvmem, >>> char **pvs_name, >>> struct qcom_cpufreq_drv *drv) >>> { >>> + int msm_id = -1, ret = 0; >>> int speed = 0, pvs = 0; >>> - int msm_id, ret = 0; >>> u8 *speedbin; >>> size_t len; >>> >>> @@ -275,8 +284,30 @@ static int qcom_cpufreq_ipq8064_name_version(struct device *cpu_dev, >>> get_krait_bin_format_a(cpu_dev, &speed, &pvs, speedbin); >>> >>> ret = qcom_smem_get_soc_id(&msm_id); >>> - if (ret) >>> + if (ret == -ENODEV) { >>> + const struct of_device_id *match; >>> + struct device_node *root; >>> + >>> + root = of_find_node_by_path("/"); >>> + if (!root) { >>> + ret = -ENODEV; >>> + goto exit; >>> + } >>> + >>> + /* Fallback to compatible match with no SMEM initialized */ >>> + match = of_match_node(qcom_cpufreq_ipq806x_match_list, root); >> >> Aren't you re-implementing matching machine? Or actually - the socinfo >> driver? You are doing the matching of compatible into SOC ID second >> time. Just do it once - via socinfo driver. > > The issue here is that if SMEM is absent, the socinfo driver can > not function and this is a contained workaround OK, some short paragraph about this should be in commit msg though. Best regards, Krzysztof