From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1E4ECAAD8 for ; Tue, 20 Sep 2022 08:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231398AbiITINj (ORCPT ); Tue, 20 Sep 2022 04:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbiITIMw (ORCPT ); Tue, 20 Sep 2022 04:12:52 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1676555B; Tue, 20 Sep 2022 01:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663661473; x=1695197473; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=NpXFnndhkQG9hC09OmD04EE4e1t8OODVtE0sPkSoK7I=; b=DmJcOwMqeZRFmOxuome3v/k3B7g/1+epzgEhkWX7SAvXTTJXnbu3xrF4 t6VFZF99fE/21FHqz33JnN229ehuwBpQ6c5cTNvCef2RBI0GuUyamyvV1 G/Pzi2AUhENxsv9N+kielpsMrZ7XmyUE874W/XeO1chZLuGjDqsGu2IRQ snVljn7OxOhsOCSrvrvneLSNfrAKaXBJB7VD7VCEjcK8QAlE7MTYUxLOw m2QlfvHFHczYD5XybWlcBxo8pAWLt9Ju30Pe1/RUznTRYuCnkXouYnwod XhllsKs2Qdb62ma9BlZfMjsT1uos10MFNDCoRkY0ThO+hJB8g4QDPccQ5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="297222696" X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="297222696" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:12 -0700 X-IronPort-AV: E=Sophos;i="5.93,330,1654585200"; d="scan'208";a="614304129" Received: from bdallmer-mobl.ger.corp.intel.com ([10.252.59.238]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2022 01:11:10 -0700 Date: Tue, 20 Sep 2022 11:11:08 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jiri Slaby cc: Greg Kroah-Hartman , linux-serial , LKML , Vladimir Zapolskiy , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 05/10] tty: serial: extract tx_ready() from __serial_lpc32xx_tx() In-Reply-To: <20220920052049.20507-6-jslaby@suse.cz> Message-ID: <3c92a9b4-c531-d960-a3cd-827c42f7f48e@linux.intel.com> References: <20220920052049.20507-1-jslaby@suse.cz> <20220920052049.20507-6-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1092543553-1663661472=:1766" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1092543553-1663661472=:1766 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 20 Sep 2022, Jiri Slaby wrote: > The condition in __serial_lpc32xx_tx()'s loop is barely readable. > Extract it to a separate function. This will make the cleanup in the > next patches easier too. > > Cc: Vladimir Zapolskiy > Cc: > Signed-off-by: Jiri Slaby Reviewed-by: Ilpo Järvinen I noticed that wait_for_xmit_ready() uses < 32 for the similar check which seems fishy... -- i. --8323329-1092543553-1663661472=:1766--