From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011027.outbound.protection.outlook.com [52.101.65.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 029C234752D; Wed, 22 Apr 2026 11:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.27 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856903; cv=fail; b=Whg6nTr84SngP9rwW8gZ0I2FUvbpRlxB/Dnbvur2K7xuFfEh9Grr8Xd8nd3wwbBIY+B0pFYhpkA1kfoSByPvpihKZdlft7ReRGqgAo4ZKIdJU7Cm6Ooyr41ANCMucvWtrisQBkqFNO4xtNAQTJWmOx0hhVXEHlPYGH4GNtfgOZM= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776856903; c=relaxed/simple; bh=4vcxPNtWjKCsUmko6Kco6G3ajpGOCwPm90/hjTj+T10=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=mCc6VstBefREYQpmFlYiV2M55SL4ZWc7h/SP9nYnQlZaSOoqrMF9Wiwsv8esoYfWg11rUyNNpus9e/gp10W5WgE20ZSqqky1fyzdzi/wy0kDBR73pqf+3LPvi52rd7DuVIyEQu7MpmX7ohlCMwDbCexxQ0jldO1MEH4jhTRwc5k= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=kOGFGYss; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=kOGFGYss; arc=fail smtp.client-ip=52.101.65.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="kOGFGYss"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="kOGFGYss" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=twZmbclap3OW8g2epoXRwP3weMEkZMWj/hSJDdPKjw8ERWadxFqDl2iwx94uVCdQAgXONWjZZieUxPwAQA6sXUHEEWozkAlb/Ast8lJFM9Evq36bXsW4/xQcy3QGIJ3zSW0/Ta/FSVZZuIIcOosg0Btac9YvGEFvEtOnw8wSmQOp094ta/nvHxoyGlP8vIwk5iPQnV6hoIod/nfQ0TnUe/FkX6k8vhVH7b7oAjILzVFZTfsHgm518MRS3GbQppADLeDjNvyEa0HXBxNVKnB7s8xCmGTREZK6RpmY2AYYJmgUHZpdQpdmYbvurpexBJxeYLhBb0iAXaGzZ65w+DiU/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRe9EqiFAovWSOsCTQgP3z0rSn9JWxwemwdeWUq7cLU=; b=dpvSObxVO8mMmBKfpIPMgQAr2wCgTQxxEwiyiXyEIUyDo3OnPm+8mj8kiWzrnDKnaiUIrvaDoOtiVH3Me5Bd9VYk0lWCCB2VJumkx9qRUNgs+6yJtYNtiwi++/xulKw01qVKOUNowMxakXzrTWYokIr1xEOMhKZlad1Ypi9P9lCdPFb/xMDgXNkOJVIQzAbwoVKX9cbzK7HrXHeQrcDn+f7DlNxLYpUQgLuhgfT3TN218YmVvULZTag5UPpCvJSGufYeCnzntfPBJYK0E/oSeFtWsYHzOSnJDMVUcpbMRaoPwDkY026OYkw/BeUPd/e4/gAFN/Y16gmfpwT1bpvu4A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRe9EqiFAovWSOsCTQgP3z0rSn9JWxwemwdeWUq7cLU=; b=kOGFGYsspvJM0Uw3Vr7pII3oacLwRX4nYvq6/Hp1B1jSY0bHY2r0yhCz92okvtXcqN8QjNEDduTto8GbTB1akp/f3VjOE4azgqjqsTp8nGeRIZC0exLWQkoyrGTjmfj9Ag/Xe0T+KtMm2syLq6/sURuDbB/4GkcAWImdgT8r8x0= Received: from CWLP265CA0535.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:18d::7) by DU0PR08MB7834.eurprd08.prod.outlook.com (2603:10a6:10:3b5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.33; Wed, 22 Apr 2026 11:21:33 +0000 Received: from AMS1EPF0000004E.eurprd04.prod.outlook.com (2603:10a6:400:18d:cafe::d0) by CWLP265CA0535.outlook.office365.com (2603:10a6:400:18d::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Wed, 22 Apr 2026 11:21:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS1EPF0000004E.mail.protection.outlook.com (10.167.16.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Wed, 22 Apr 2026 11:21:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vwRpZX1z2+k68F0g+GF9rUGZbPZPldeffOrq12DuyrRrvQkPLsbORlRbg5xEeG6EuPhq5yG4cCuiCvHHQmQf7Jn17OJn+DRy+3kgsi4cP/kqg5KqZWVnHFUWDQhpu7KBsEZ5Vl8fpDl36IZOm2AkzfRa4zRnwNkO+KWWQtte29WT6JcZIi/RV+ymvGAG51RwvW5d23F/nhhLJq+N91XCInoR+6H+S3PaUN1eJKZikUZHzqqUDuDbfL6w1IiUq2KFRjd2PO6ZzngHTagp1wAb8rU1lh47ZZU8Qh/lCVmfwtc5sFmffvxH1Jg5rRy2sC2WI76nN1MsQCokYIuztQTpMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VRe9EqiFAovWSOsCTQgP3z0rSn9JWxwemwdeWUq7cLU=; b=H7Qojv1/IzR7MaOzNIjPWk09FQqbVr9mSN0WEIy3T9n+OezxpEnOAMy0998B/o5p8B+MYKdRtNGgO7odFGlXZkoeEkcf4Z6HDQYgDos38E35JjKLH5yk73z8CULP9tY5mOp24Wyr3ZTid1Cv8KddRD/8zqXteEgrq+/VNujmQxdHyAixij98QUPr8FLJoLXaZ7rT0vI5FFvd0he/0AAjZxaUyFkMGgdQ3ARLOaKYaXEKKJ5wX/cA46k9f/uQCwl+BUu9gdYyhTwKPWlC8s388JjeXwGnBF9mw4cSaowzJ0USWsDmDfeQjrsdulNm3kvz7KhOEdXWnUBRCvc5XyENmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VRe9EqiFAovWSOsCTQgP3z0rSn9JWxwemwdeWUq7cLU=; b=kOGFGYsspvJM0Uw3Vr7pII3oacLwRX4nYvq6/Hp1B1jSY0bHY2r0yhCz92okvtXcqN8QjNEDduTto8GbTB1akp/f3VjOE4azgqjqsTp8nGeRIZC0exLWQkoyrGTjmfj9Ag/Xe0T+KtMm2syLq6/sURuDbB/4GkcAWImdgT8r8x0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by DB5PR08MB10093.eurprd08.prod.outlook.com (2603:10a6:10:4a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Wed, 22 Apr 2026 11:20:29 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%2]) with mapi id 15.20.9846.016; Wed, 22 Apr 2026 11:20:29 +0000 Message-ID: <3d154106-1de3-4cd8-9bee-53ef20245d62@arm.com> Date: Wed, 22 Apr 2026 16:50:20 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/53] selftests/mm: hugetlb-shm: use kselftest framework To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260418105539.1261536-1-rppt@kernel.org> <20260418105539.1261536-8-rppt@kernel.org> From: Sarthak Sharma Content-Language: en-US In-Reply-To: <20260418105539.1261536-8-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA5P287CA0141.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1d2::6) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|DB5PR08MB10093:EE_|AMS1EPF0000004E:EE_|DU0PR08MB7834:EE_ X-MS-Office365-Filtering-Correlation-Id: 976ac14d-1a03-470a-dee9-08dea0614ec0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|1800799024|366016|7416014|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info-Original: ckIpzihaNqIkVKDrW9uz/RMMiqUMcmII2psPw1aQZ6wDLtNd3WYP+ibGCeYjyC0E+Rlzcp4fuJ8esgK/Ne9QYSHdDEdKKWVH+eCS4DW8LkQ5Y4Twk1Tg+jjrxJ5+ugM7/336P4NbRS195l5iBM3rBC5ow0jb5nfyu2EZ8Fi9Pqt310oZxVj0uwNmEG7KiRRC6cR0tOakN/UsU77NvL8sEF5l2d2PUYg/3878+TvizzI53j158oQQGj2u9EpwEdJkJJkxOhZzakK/hBSB7sB04Oej76WiEtLrQW62B3g/A7LIYjNBuo0/XtevAjOGk1NEJrkD+aRqUMuZFIWGeDO0oEhajzLLO21c0AOiX51Ov4Qs35YFwGTAjVVeF8Vf4EwmdGU+MTdDJ5iezU8lst60PbABNCHCDSJ1SPBBNd1z4RM6kFPnEmP4vCqIfW6kX1J10BKlOsczaOOsNGjkeKMocuxTD5WoZwI0YiobiVkswDj3dAv6sodkJ/SZI0omMkYbKuhTB4aLoN2sax2G/p2YaO1krZZrQS0mqRUxKhgAYjIBlZOZ24p5N4VsvawoKYGmhCCFYUXscuZ3bMALWv1hnIVPR2cxYSbssi0PGfngg2CL7Nf62RV4Pc2h2/yakYogv2DBxA94HDg03q+1QM3ai9jXixtFbdd3r/iAJDyRyISddyMkPdC8hiVtlrU/NAD+2nP+NiKi9u/hNElA5/NYRwvCJbgv3bD8uGTiMp4K79A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(7416014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: dcwKbBu8LvY8znxlVWZzHM3C0u+IJJqbauoigjdqtf4D6WETVQEIEZFw0UXjkEuljwnUHp/srsmCgXZXj24fDxli1LT7QJO0mB4imnBGF4Kp7NX7ZnpTMaUvMmFjdPaDGqhkkNcUvo00Uvi+pqtmFKB/WSwf3ro0U26eYpEx4DQryPL7UlDhDeB19SaJCNstYQ/WaREF/lPEuv9r7UnYQJe6o3Zmj7l1li2d5JRsTOYSKTywpoADVs4bsnX01Hn9obanPZxHk9e+Uv4CPpu5yhhc/9130wSZcEwr6E2pgiln+p6VWOe3TSx0RKIslR58WNH/NTh0mWurhMQuIjMobA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10093 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a73c0ad5-aef8-4736-e19c-08dea06128a8 X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|1800799024|35042699022|36860700016|82310400026|7416014|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: 9561qE5ipVGfGguCu2fxSCCRScMDgLFWE8gy8y2wRSfjgvqr0aMiYlfQFNKqltrqzn9rZ2bLutSPfSk+az2e7cj1GcV2NzEc6qutmKZgpP2NN0k7rx8VeTbPkm1zVpH9fHKspFBOqsgYw6oO1x6kJMqd/Jh+ExR+CJVIt+Ci0x4DtVghkf71rqKJKrkQ62jt0vD23/n8Y9EZ/OcIp69MVCTxu2dWHOst27c1bITK4cotqlyhokuP3NZY9sZFwkzlBooow/eaGBp4VqYHeOLIcwIoYCdv4BCvaWw1Ve3aXz0TmioAYTqY24ZgIPomEHIDegFf1rUUZ0thnHM8JSCdMRExhDN1PgnKOj2roZs6G7HzGIRxdklEe1u9zc5GEgFYkdk10QlJ8z9q+ti0GAiqFAjU1NXeIl9oXSxjS4P5UU8nauiauPIEgsYbXzLOyU17bgOWtyj/4YN3UNWt6kx4AmlGxZoCYQGASxdc7XWKNtE2guZsphkAXA/TV5G9ftPu4RK1uPrl6PqfdGQvanT11CfwvNj7DKBnNrPDQp1ECqJBtbrKHAi4Y/e7xorEhdQgMcSCieqegI6XtBD78BooFojq9AShM5CYEizawrvWxPCjeYQ+QnYunOybv+sCuFsOF3d6ZIorJXe6cvK/CvRqk2JAP7pjum/FmVmgOM1LCTES1kV7HeXYRZkpG8Mya5JcBCd5xgmtQcuUEde3o5yxZM4PnRmruAjreGxu18CkNMeYE2Z0wc6OE4VZt4yIXj1EWR6leiVOS9hzOph99ULVMg== X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(1800799024)(35042699022)(36860700016)(82310400026)(7416014)(376014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uhmQCGxyXziQYLOnygFu66/ZQOFKhE9oCntL2VrFQw4DTj73mQxG+6by2Map2c+Q+/it8BXXyXPO4Sxjm7tJFo6dGet2zK/yODfh0Vne9i7smLPHgBoI38ed5rV9aLYTPk9OOAR6y9K38zIvwaV3ro4jSMgNuEvrK156Qktw5Xcx/O2VraH48JqNsbuU5vts/U1oUbOyhfZagQY4T9SDH8Jc4kG1jAwe9iw/8Oy7hRlHzl8A22+LgJ1xJYwR9AcVrM9k6kt3cSWI3yV0HGO4joFsgnCgSlGubfRWWH5CWmEF6RSrrLLJfrE6XqPDuM79pMJwy9lwQNC6zQuudJ6Fvxh56WxxClN0vvIhvueJH2g48yqexwGtWqvjrnjLlptaGWSF6mFdawtriPTLs2AForCMhsd1CNVL6T0pLsMZKtXa57tJ1lNyjYz3wCzUZiUC X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2026 11:21:32.5639 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 976ac14d-1a03-470a-dee9-08dea0614ec0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7834 Hi Mike! On 4/18/26 4:24 PM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Convert hugetlb-shm test to use kselftest framework for reporting and > tracking successful and failing runs. > > Reviewed-by: Mark Brown > Reviewed by: Donet Tom > Signed-off-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/hugetlb-shm.c | 46 ++++++++++++------------ > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugetlb-shm.c b/tools/testing/selftests/mm/hugetlb-shm.c > index de8f5d523084..10e4baa091f2 100644 > --- a/tools/testing/selftests/mm/hugetlb-shm.c > +++ b/tools/testing/selftests/mm/hugetlb-shm.c > @@ -28,9 +28,9 @@ > #include > #include > > -#define LENGTH (256UL*1024*1024) > +#include "vm_util.h" > > -#define dprintf(x) printf(x) > +#define LENGTH (256UL*1024*1024) > > int main(void) > { > @@ -38,44 +38,44 @@ int main(void) > unsigned long i; > char *shmaddr; > > + ksft_print_header(); > + ksft_set_plan(1); > + > shmid = shmget(2, LENGTH, SHM_HUGETLB | IPC_CREAT | SHM_R | SHM_W); > - if (shmid < 0) { > - perror("shmget"); > - exit(1); > - } > - printf("shmid: 0x%x\n", shmid); > + if (shmid < 0) > + ksft_exit_fail_perror("shmget"); > + > + ksft_print_msg("shmid: 0x%x\n", shmid); > > shmaddr = shmat(shmid, NULL, 0); > if (shmaddr == (char *)-1) { > - perror("Shared memory attach failure"); > + ksft_perror("Shared memory attach failure"); > shmctl(shmid, IPC_RMID, NULL); > - exit(2); > + ksft_exit_fail(); > } > - printf("shmaddr: %p\n", shmaddr); > + ksft_print_msg("shmaddr: %p\n", shmaddr); > > - dprintf("Starting the writes:\n"); > - for (i = 0; i < LENGTH; i++) { > + ksft_print_msg("Starting the writes:\n"); > + for (i = 0; i < LENGTH; i++) > shmaddr[i] = (char)(i); > - if (!(i % (1024 * 1024))) > - dprintf("."); > - } > - dprintf("\n"); > > - dprintf("Starting the Check..."); > + ksft_print_msg("Starting the Check..."); > for (i = 0; i < LENGTH; i++) > if (shmaddr[i] != (char)i) { > - printf("\nIndex %lu mismatched\n", i); > - exit(3); > + ksft_print_msg("Index %lu mismatched\n", i); > + shmctl(shmid, IPC_RMID, NULL); > + ksft_exit_fail_msg("Data mismatch at index %lu\n", i); ksft_print_msg() and ksft_exit_fail_msg() are printing the same thing here. Should we remove the ksft_print_msg() to avoid redundancy? I've run the test before and after applying the patch. The output has been correctly formatted into KTAP format with no change in results. Tested-by: Sarthak Sharma > } > - dprintf("Done.\n"); > + ksft_print_msg("Done.\n"); > > if (shmdt((const void *)shmaddr) != 0) { > - perror("Detach failure"); > + ksft_perror("Detach failure"); > shmctl(shmid, IPC_RMID, NULL); > - exit(4); > + ksft_exit_fail(); > } > > shmctl(shmid, IPC_RMID, NULL); > > - return 0; > + ksft_test_result_pass("hugepage using SysV shmget/shmat\n"); > + ksft_finished(); > }