From: Krzysztof Kozlowski <krzk@kernel.org>
To: amitsd@google.com, "Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Lee Jones" <lee@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Badhri Jagan Sridharan" <badhri@google.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
RD Babiera <rdbabiera@google.com>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: maxim,max77759: add charger child node
Date: Tue, 23 Dec 2025 14:32:24 +0100 [thread overview]
Message-ID: <3d156c45-b55d-4ca4-95d6-0d06e067bbdb@kernel.org> (raw)
In-Reply-To: <411802b6-517d-497e-bf7b-183e6e6d7a64@kernel.org>
On 19/12/2025 09:17, Krzysztof Kozlowski wrote:
> On 18/12/2025 23:49, Amit Sunil Dhamne via B4 Relay wrote:
>> From: Amit Sunil Dhamne <amitsd@google.com>
>>
>> The Maxim MAX77759 MFD includes a charger function. Extend the max77759
>> binding to include the charger. Also, update the example to include
>> charger.
>>
>> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
>> ---
>> .../devicetree/bindings/mfd/maxim,max77759.yaml | 33 ++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
>> index 525de9ab3c2b..1cffdf2e5776 100644
>> --- a/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77759.yaml
>> @@ -37,6 +37,30 @@ properties:
>> nvmem-0:
>> $ref: /schemas/nvmem/maxim,max77759-nvmem.yaml
>>
>> + charger:
>> + type: object
>> + description: This is a dual input switch mode battery charger for portable
>> + applications. It supports wired and wireless charging and can operate in
>> + buck and boost mode.
>> +
>
>
> I do not see any improvements, so same comment: this should be folded
> into the parent.
>
> Please read DTS 101 slides or writing bindings or any other talks...
>
No responses to my emails for a few days, so I assume discussion is done
and I mark it as changes requested in patchwork.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-23 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 22:49 [PATCH v2 0/5] Introduce MAX77759 charger driver Amit Sunil Dhamne via B4 Relay
2025-12-18 22:49 ` [PATCH v2 1/5] dt-bindings: mfd: maxim,max77759: add charger child node Amit Sunil Dhamne via B4 Relay
2025-12-19 8:17 ` Krzysztof Kozlowski
2025-12-23 13:32 ` Krzysztof Kozlowski [this message]
2025-12-24 19:11 ` Amit Sunil Dhamne
2025-12-24 19:07 ` Amit Sunil Dhamne
2025-12-18 22:49 ` [PATCH v2 2/5] dt-bindings: usb: maxim,max33359: Add supply property for vbus Amit Sunil Dhamne via B4 Relay
2025-12-19 8:19 ` Krzysztof Kozlowski
2025-12-18 22:49 ` [PATCH v2 3/5] mfd: max77759: add register bitmasks and modify irq configs for charger Amit Sunil Dhamne via B4 Relay
2025-12-18 22:49 ` [PATCH v2 4/5] power: supply: max77759: add charger driver Amit Sunil Dhamne via B4 Relay
2025-12-21 7:31 ` kernel test robot
2025-12-18 22:49 ` [PATCH v2 5/5] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode Amit Sunil Dhamne via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d156c45-b55d-4ca4-95d6-0d06e067bbdb@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=amitsd@google.com \
--cc=andre.draszik@linaro.org \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox