From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE0939B49E for ; Sat, 13 Jun 2026 09:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342652; cv=none; b=bnJuKHFzzb3ymYbe1vRUE93SVktfsEJxRj5WFxuR2FZGxumY18HJdw3R7BkrGOXJPc8G5yVTsO693Yivfc2yy9SisPDt38wB1Q7uRu1NLE4kYPzxkBIszaEDPDcBm78+Se0CPt8Qmwd0IpCdajh2n0FVaPv03n2+vG8opw9+Eg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781342652; c=relaxed/simple; bh=8cBHyxhK3M1DiH0ERPP2rDyVMsOU2ZvsmDqgPW5FrxI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ELUG+oYfcEbPSSKnVD9LMmxE2/IygU3X7TlhTm3n31G0P/NoZ4C6Or6iuRyltuG8h3fdVYiRrDwEGR+/Pjtb+hig/j8fVC0v24i3fjoq9pguMODHiR2EjjE78/Z9ndSGKTa3oBEZD16sxSBV5UT+2fGb9ct7LDojaqmpWF87818= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XXseLHuH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MFPX4uLp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XXseLHuH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MFPX4uLp" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65D6fHBs1791405 for ; Sat, 13 Jun 2026 09:24:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4S/HL/NoFo2ZHKsSRY4P5EPW0iAMj/MKdhO3xQ8vG90=; b=XXseLHuHd5l61azv uiiExBTObCduDSU8Sxvqz3MZwx1rLS34gSFrsJFXlMOy1kvg02/jMgiqfo77TSFR rheZ7sjCvjxAms7H+LedobecItRjAY/dEiHN5rLUVMmfo4Autxh9MBkqzRhAkSnk NKpGq65HnnOLoZU2GByWNRa7WBQ9ptXm2xA1bsf4RXuZ6FowVaPTIMrWMIZauSgZ TMky8B1AUm5fYi0OB4qQ2eA+5HeRHVzRGpczrCQhHLc9h3E0zMDN73qMgSKuYq2p YDUnEsYcXLv3XvInqBTKo/QEHr7kGXIMhLjekJJgp60K2CEmSfHuqqCb/h+F6aq6 siw5UA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eryc6rner-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 13 Jun 2026 09:24:10 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5176d949c58so39919121cf.0 for ; Sat, 13 Jun 2026 02:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781342650; x=1781947450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4S/HL/NoFo2ZHKsSRY4P5EPW0iAMj/MKdhO3xQ8vG90=; b=MFPX4uLppbkMVpUdTfukZ3Pk2dkilfZ2zlWHFGsahvJ2iq3SKaS3+j1uY0FGByOW0J 5QJnY5wPlzo+PT+Jqmw88LB2su5mFTPAJMxZPgVGuLpcgAW4lgFPAeEMdh0g/S+6uhag QBBqei08+e2DycMAXKGwsxnfIRvdYVfD9xiNvc5qNNPH3RplDF2OB+YskR5ME6awqgTS AYuNvS1GiPYv7uzW1rNiw+GjOgYfXhtLeT7mpHNvrdR8SHbXocnkpegyBBVqg3ahB/Zf mZxag89/+uIxdRqAIzx24ZFmDHG/UFabUT1nhwRPtXyoEciPfzeZ4feDRyo+CCD75W0Q d9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781342650; x=1781947450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4S/HL/NoFo2ZHKsSRY4P5EPW0iAMj/MKdhO3xQ8vG90=; b=Wjl37LkxgdMpU4exKqE8PqXFM2qyftu1K/YEIEN7TWTEN0lT1T/F6GUADvpioJS6WY kjHxkWrI0ffPz9ltj+3uB35OLgMGSThlECUjf3BtgqQbqEG/ShUJkTgATazi3w7UPuXs Zom8kee5IEn8Fi3nGKcT56f6TwfdUAN+bntCYBFk7PmaKoPNcXuHm1quxSPWEt+8jZzV H39ogjDfbPH/1ul+qsgMCTfQXolp0gwC+meYmjtcE68HQP5XCw+ylO7IDVPzpxlt0AFs DgOot+Bby95Z1mddhHhQFmu+PhOTloutiVRnVofMzAv9R+L0jCDndop/AlXOnjpSAidI MSTQ== X-Forwarded-Encrypted: i=1; AFNElJ+8CWKoJFqZodv2ruznefay8AsEAFNFvnLUYa43QaEcjtrp98snmI6TO/KDrY/E5ABZf7DwLOklVNLBamc=@vger.kernel.org X-Gm-Message-State: AOJu0YxbZvrsbt1Od/VVqoZPZTeGlWnIWFK82bT3oDxooEk+y1aeOVFm xbQ89E7hwC08H/Hot1Hfqqt/HMxt754EmjYemhdToTI/3k3rJr2bjpG6wgauo6BvMOXnuDCMySv yqMoWsA+MEs4Jl2R3PQyFaBh0mtGOQnq3qqbb9PLxPix9Oax+5fFWpoS2PdUgbI+FpKY= X-Gm-Gg: Acq92OFVKHpROyi6eYp0UyO38FPXdaVdwLm6HIlu2a+lUODLRjF+B6qeOniHHr2ClcZ 1iewHyT6JV55g6iP32Gj2LJV8EViMFAEUz0SegrakNsKlY1lf6b3rTxbfgeYMBh3btg6PMwmU3G hAKDTx7JdYsIAQ51ABq7bGyF379MWqenb+azfvBJfmepTNFZFC2/95iJD+jmM0Dh/35n2jmBGmX EH1DdMmMbEbd3cWw//QNhDeIye1cccKhxon17B2Xr8hsh7tThLTRPBkD0MToeFhaFChD6ClW5kw 1Y10fmNtT5OVGFsUnLIWIUCZujtDu8hCkN9p4K+53m9hU53aBWM2JK/Jg+BNWnVCRsv7p40GKZK m4ARa8lCPNq1aJ+6UQcDxy53kKt2BTn+4V7BlFRBhsTOSAD1QMJ86kA== X-Received: by 2002:a05:620a:1b99:b0:915:9e84:85ee with SMTP id af79cd13be357-9161bc214a6mr962484685a.15.1781342649977; Sat, 13 Jun 2026 02:24:09 -0700 (PDT) X-Received: by 2002:a05:620a:1b99:b0:915:9e84:85ee with SMTP id af79cd13be357-9161bc214a6mr962481285a.15.1781342649407; Sat, 13 Jun 2026 02:24:09 -0700 (PDT) Received: from [192.168.1.73] ([92.247.57.178]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8341840sm201048166b.43.2026.06.13.02.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 02:24:07 -0700 (PDT) Message-ID: <3d4e0147-8e62-4872-b881-1452f5e09e85@oss.qualcomm.com> Date: Sat, 13 Jun 2026 12:24:03 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sm8550: Add JPEG encoder node To: Bryan O'Donoghue , linux-media@vger.kernel.org Cc: mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260612194417.1737009-1-atanas.filipov@oss.qualcomm.com> <20260612194417.1737009-3-atanas.filipov@oss.qualcomm.com> <8d230cca-2023-4a13-876f-d5db8eb200a1@kernel.org> Content-Language: en-US From: Atanas Filipov In-Reply-To: <8d230cca-2023-4a13-876f-d5db8eb200a1@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEzMDA5NCBTYWx0ZWRfX3AaCqfcpZ0/5 sVM1kmGfkLhxk8xcd9cfXBRU7ChWNry/ZBZmOr4plbAZS+hnV9He3CEchd7HJmB/sSQSyVuwX8o rBvLPajGYVOxS6WQYi8bShS48ZVL9LE= X-Authority-Analysis: v=2.4 cv=Oop/DS/t c=1 sm=1 tr=0 ts=6a2d21ba cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ybD9qRDIDfZaXNPQ7Ca20A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=bWlYEoAHg9xnmN_O1lcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: 31XFyE6gZyr8JLdjXPa1gun2xA1Rxx7O X-Proofpoint-ORIG-GUID: 31XFyE6gZyr8JLdjXPa1gun2xA1Rxx7O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEzMDA5NCBTYWx0ZWRfX2NrcV7UPDrjr hhuFCEvLcY8l7PYGZxLiY2JoU2zJ+/WSAKy5nLy5E++Idz4wyiMrveCmxJvm9kd49/Ww27u+Y2/ x7ne2/3qI1pxjmTuytwEqyPY3h6vHp6N2njoZPwA/tScL3K+W4Pon3x6BA2V8N1+0/m8jVSaR5K iCUDNgrK5rGsilKnTWYshVH7WOyTsdghQfds7WWf5GxUpDI+7eKTkXOy6XTGYuQjJqmLYL1vZck C531sI3xQBLFqoIUkJA1rbLPNb6jtMxLB//jsutw1DB02e2XiZMf0d6GulQ4QSOpMPX3uOwZO6G zrmxojUnxBIf+gpdiPffQoOVtA5gWq4fX8GLO7ck1xwW/Qb0kIlL9vZHucmNPn0UZF23CFMXXF3 VNtdDL6HbOERnWsqvXr6w5Wc9YNDcBi+ejE2L1my6xyKXX/YGfUFMSzgZQHOGD7xkj7iSd/b5gW XpQOnspLOTKZeSyFtUw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-13_01,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606130094 Thank you for the feedback. I understand the reasoning, but I respectfully disagree with this approach for the following reasons. While it is true that the JPEG encoder shares the same camera NOC and power domain infrastructure as CAMSS, that is a hardware topology detail — not a sufficient justification for imposing a software dependency. The driver is a fully self-contained V4L2 mem2mem encoder, implemented like every other JPEG encoder driver currently in the kernel (imx-jpeg, s5p-jpeg, mtk-jpeg, nxp-jpeg). None of those are sub-nodes of a parent ISP or camera subsystem driver. Making the JPEG encoder a sub-node of camss would introduce an unnecessary and artificial coupling: the JPEG encoder cannot be probed, built, or used independently of the CAMSS driver, even on platforms where CAMSS is disabled. This directly contradicts the kernel's principle of independent, single-purpose drivers. The shared hardware resources (clocks, interconnects, IOMMU stream IDs, power domain) are already fully described in the device tree node and handled by the standard kernel frameworks — there is no functional reason to nest the node under camss. For these reasons I would prefer to keep the JPEG encoder as a standalone platform device with its own DT node, consistent with how all comparable JPEG encoder drivers are structured in the kernel today. afilipov On 6/13/2026 2:14 AM, Bryan O'Donoghue wrote: > On 12/06/2026 20:44, Atanas Filipov wrote: >> +        qcom_jpeg_enc: jpeg-encoder@ac4e000 { > > One key bit of review feedback I gave in the previous leaked version of > this driver is that since the jpeg-encoder is part of the CAMSS block it > should be a sub-node of camss as OPE, CSIPHY and other blocks will be. > > Please take that feedback onboard in your v2. > > --- > bod