The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: "vjardin@free.fr" <vjardin@free.fr>, Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: lx2160a: fix incorrect pinmux
Date: Mon, 24 Aug 2026 11:47:43 +0000	[thread overview]
Message-ID: <3d4fe161-895e-4820-a99d-8cd5fd6d9ad2@solid-run.com> (raw)
In-Reply-To: <20260824-for-upstream-lx2160a-pinmux-fix-v1-1-33a3c8d5ea8a@free.fr>

Am 24.08.26 um 00:24 schrieb Vincent Jardin via B4 Relay:
> From: Vincent Jardin <vjardin@free.fr>
>
> For gpio1 value set for pinctrl is outside the mask and so will do
> nothing.
> Add the missing offset for value field to be the same as the mask as
> expected.
>
> Fixes: 284ad7064aaa ("arm64: dts: lx2160a: complete pinmux for rcwsr12 configuration word")
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 1d73abffa6b7..b9f079c49e19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -1803,7 +1803,7 @@ fspi_data74_pins: xspi1-data74-pins {
>  			};
>  
>  			gpio1_31_28_pins: xspi1-data74-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 15)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 15) (0x7 << 15)>;
>  			};
>  
>  			fspi_data30_pins: xspi1-data30-pins {
> @@ -1811,7 +1811,7 @@ fspi_data30_pins: xspi1-data30-pins {
>  			};
>  
>  			gpio1_27_24_pins: xspi1-data30-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 18)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 18) (0x7 << 18)>;
>  			};
>  
>  			fspi_dqs_sck_cs10_pins: xspi1-base-pins {
> @@ -1819,7 +1819,7 @@ fspi_dqs_sck_cs10_pins: xspi1-base-pins {
>  			};
>  
>  			gpio1_23_20_pins: xspi1-base-gpio-pins {
> -				pinctrl-single,bits = <0x0 0x1 (0x7 << 21)>;
> +				pinctrl-single,bits = <0x0 (0x1 << 21) (0x7 << 21)>;
>  			};
>  
>  			esdhc0_cmd_data30_clk_vsel_pins: sdhc1-base-sdhc-vsel-pins {
>
> ---
> base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
> change-id: 20260824-for-upstream-lx2160a-pinmux-fix-6d09e82bd5cb
>
> Best regards,
Thanks!

Reviewed-by: Josua Mayer <josua@solid-run.com>

  reply	other threads:[~2026-08-24 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 22:24 [PATCH] arm64: dts: lx2160a: fix incorrect pinmux Vincent Jardin via B4 Relay
2026-08-24 11:47 ` Josua Mayer [this message]
2026-08-24 13:15   ` Vincent Jardin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d4fe161-895e-4820-a99d-8cd5fd6d9ad2@solid-run.com \
    --to=josua@solid-run.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox