Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

Baolin Wang
2018-08-06T07:33:16Z

Hi Pavel,

On 6 August 2018 at 15:09, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> > In current implementation this file on read returns the number
>> > of remaining repeat intervals. I'd add that to this description.
>>
>> I saw Pavel's comments that he did not suggest do this. So I will keep
>> the original description?
>
> If that is accepted, the code should return originally written number.

But I think it is more reasonable if user can know how many
repetitions were left. So for your hardware case, can we add
pattern_get() interface back to get the repetition number?

--
Baolin Wang
Best Regards