Re: [PATCH v6 12/16] dmaengine: tegra-apb: Clean up suspend-resume

Dmitry Osipenko
2020-01-30T20:06:19Z

30.01.2020 22:00, Jon Hunter пишет:
>
> On 30/01/2020 04:38, Dmitry Osipenko wrote:
>> It is enough to check whether hardware is busy on suspend and to reset
>> it across of suspend-resume because channel's configuration is fully
>> re-programmed on each DMA transaction anyways and because save-restore
>> of an active channel won't end up well without pausing transfer prior to
>> saving of the state (note that all channels shall be idling at the time of
>> suspend, so save-restore is not needed at all).
>
> Maybe just update the commit message to state that the pause callback is
> not implemented and channel pause is not supported prior to T114. And
> then ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks, I'll update the message.