From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0361AE743D3 for ; Fri, 29 Sep 2023 00:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231742AbjI2Aaw (ORCPT ); Thu, 28 Sep 2023 20:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjI2Aau (ORCPT ); Thu, 28 Sep 2023 20:30:50 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61C241A5 for ; Thu, 28 Sep 2023 17:30:48 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-65b0dad1f98so54567526d6.0 for ; Thu, 28 Sep 2023 17:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1695947447; x=1696552247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=atEB7wjnfyIdR+cI94PXlHFbCfo6brMiQMFpy3s241U=; b=cijoMD3UATZPstSif7qtw9XrrWff8Ty/4+1i1c3pfR6GeTs2gUOaj5mnaB00ar9TvQ URTXi7rF4JzJ8qWhqSLlgv2mgYJhfEZLZ4QZyjZItSyJLW7EndY16g8IbR7unadVTZWH LNNg8GoXQY2vo/KiiokMnWANnE2yBv5p8nSkcL6yvylsN8768qe/0JrSoqOe8vvn52+p aFir0WFmg9kIe4dboae7okpeSnGyxPdb0wF037m5e3MvSobK+r/mrX2EZ5ZsWPr5Oab9 1ym9f4E8A0PFSTabe94Fw2+d3zME1hIJj3k7bHNhj2RHwKmIbWzINuCyglXK5sQ0jv5I pzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695947447; x=1696552247; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=atEB7wjnfyIdR+cI94PXlHFbCfo6brMiQMFpy3s241U=; b=dCweZIeFUAjW79gpSOq9UcD/SLZM7fmyqE6Z57bvaTE0rchlI+AOkG+LisWUf2V9uc uNqm3+Bw8q4CtE6OkTozZltWzBesNmyUd0NkyTgvtq7Kf3r+XALXyuJW28LPkLGc73j7 BIHN6OTKbtLRk9z31N/EjUyBDcIR2ROFIpnr7+cvAkwxVmI6Yy7vqO4qma/cNKUu3v22 WpxhfD80H/YxbGsC5JNLA2dyu8X57DS7UZzsImI8dt2Pl3Ex8LVE4R5xD/P1blojhUIb T2QFeurveJqmKtCXdN9A4kbliLInlABw3QkVOJFwquxGW4eEyIT9vw7+Os1lwQ9KBK+p k1mQ== X-Gm-Message-State: AOJu0YyhtneFrrlp52sHquyYLjD0w38663/xOmrVe+Y1ENG6TRC5kXU9 2KCDe1LEsiDaUcHl4d7WB3a2Nw== X-Google-Smtp-Source: AGHT+IEYm7+id3//cfxcIDRfW/DYDioXQBn/ZqKu09zqWg0PZQxdEAy8zuztSY5h7LmqGu3r0JstLg== X-Received: by 2002:a0c:cb88:0:b0:65b:1468:8210 with SMTP id p8-20020a0ccb88000000b0065b14688210mr2774211qvk.23.1695947447439; Thu, 28 Sep 2023 17:30:47 -0700 (PDT) Received: from ?IPV6:2600:1700:2000:b002:5086:8bae:a4b0:bdad? ([2600:1700:2000:b002:5086:8bae:a4b0:bdad]) by smtp.gmail.com with ESMTPSA id q5-20020a0cf5c5000000b0065d105f6931sm759933qvm.59.2023.09.28.17.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 17:30:47 -0700 (PDT) Message-ID: <3d9eb660-e255-4477-a04b-6db8d249a20d@sifive.com> Date: Thu, 28 Sep 2023 19:30:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] riscv: dts: renesas: rzfive-smarc: Drop dma properties from SSI1 node Content-Language: en-US To: Prabhakar , Geert Uytterhoeven , Magnus Damm , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Rob Herring , Krzysztof Kozlowski , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Biju Das , Lad Prabhakar References: <20230929000704.53217-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20230929000704.53217-5-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Samuel Holland In-Reply-To: <20230929000704.53217-5-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On 2023-09-28 7:07 PM, Prabhakar wrote: > From: Lad Prabhakar > > With DMA enabled audio capture/playback has some echo noise. So for > now switch to PIO mode until fixed. Is it really appropriate to work around a Linux software bug with a DT change like this? Remember, the devicetrees are used by software other than Linux. Regards, Samuel > Signed-off-by: Lad Prabhakar > --- > arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi > index a8573fdfd8b1..85f96e24a96e 100644 > --- a/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi > +++ b/arch/riscv/boot/dts/renesas/rzfive-smarc.dtsi > @@ -6,3 +6,8 @@ > */ > > #include > + > +&ssi1 { > + /delete-property/ dmas; > + /delete-property/ dma-names; > +};