From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-70.mta1.migadu.com [95.215.58.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8A523BBFC3 for ; Fri, 21 Aug 2026 09:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787305347; cv=none; b=cTGvLvprnFSQBye4kRKv5Lq88aoEKVmOBGiWGmRJ53QUdAf3xqauLBl9dyt/0MBNcrAjfiNtQwMWFSPkZfO0HcXNIvtgb5IPDaOgE53XecqIFT5nQnHHWcMlfX0mKocCQKnuqnyTqrbwOSF9qt702VcXwOcU3ZvMHVEfJr3jRUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787305347; c=relaxed/simple; bh=Rxfi0wehmMz5zSrQZjn/MPFcE7dvwqlrAiXUCl2TjJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F2+phn6sU54YGsJB2iorjWJaRiZjnFhCuQ43TPYfLAaiv6NPS5pvlixQ3Lb/VQQAuQiENE0lOBucAILRcdjZaSpmNwQ0o7O6/Q4aJDA8GX6dB9sp2ViutBqVfdk9ZuwxtJq7i/d0cYQJVPjaytG0src3gFs9NAmQa0kcO35zKks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cHmS+G4T; arc=none smtp.client-ip=95.215.58.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cHmS+G4T" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Rxfi0wehmMz5zSrQZjn/MPFcE7dvwqlrAiXUCl2TjJg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787305338; v=1; x=1787910138; b=cHmS+G4TY5jqgKS3NMRg3iDIdsN0EknzRD3ctniB+4SB8rCmixHgB7C0xDARd3KFeNJGCcX4 Q0txOPJlJTRR0p1ESa21DA4dzW13YrRYX+fVoA5U3LRbV3r4vMv1eZXh+wmYechG7WXjX/Ea9kn 3kTPY4P4wo6vfjA1cKlimuK0= X-Envelope-To: linux-kernel@vger.kernel.org Received: from [198.18.0.1] (116.128.244.171) by smtp.migadu.com with ESMTPS id e00fe8bc45fea054; Fri, 21 Aug 2026 09:42:08 +0000 X-Mizu-Trace-ID: e00fe8bc45fea054 X-Migadu-Flow: FLOW_OUT Message-ID: <3d9ee2ae-aa8d-41d3-b034-956c9003d2f2@linux.dev> Date: Fri, 21 Aug 2026 17:42:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 5/6] net: phy: propagate errors from default port setup To: netdev@vger.kernel.org, andrew@lunn.ch, maxime.chevallier@bootlin.com, kuba@kernel.org Cc: hkallweit1@gmail.com, qingfang.deng@siflower.com.cn, hao.guan@siflower.com.cn, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, Xuanqiang Luo References: <20260821070327.16147-1-xuanqiang.luo@linux.dev> <20260821070327.16147-6-xuanqiang.luo@linux.dev> From: Xuanqiang Luo In-Reply-To: <20260821070327.16147-6-xuanqiang.luo@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2026/8/21 15:03, Xuanqiang Luo 写道: > From: Xuanqiang Luo > > phy_default_setup_single_port() ignores errors from phy_add_port() and > always reports success. If a PHY driver attach_mdi_port() callback fails, > the phy_port is leaked and PHY probing continues without the expected > default port. > > Destroy the port and return the error. > > Fixes: 589e934d2735 ("net: phy: Introduce PHY ports representation") > Reviewed-by: Andrew Lunn > Signed-off-by: Xuanqiang Luo I realized I made a mistake. The Reviewed-by tag added to patch 5/6 should be: Maxime Chevallier rather than: Andrew Lunn Sorry for the mistake. I will send a corrected version after 24 hours. Thanks, Xuanqiang