From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E06C433EF for ; Wed, 6 Oct 2021 15:38:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08033610C7 for ; Wed, 6 Oct 2021 15:38:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbhJFPj4 (ORCPT ); Wed, 6 Oct 2021 11:39:56 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:22098 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbhJFPjz (ORCPT ); Wed, 6 Oct 2021 11:39:55 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633534683; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=nsnvN8SFzET/qx+VaZ+i91Lv8nnayRJHw03nzETyATE=; b=D/Z+jSsYdodT/++ZmqQAwg29ErJpeBu6d1Xce7Owshn7bNolcksmYTlW4JcYwI+2CPWhJfxe 7DP5monkMDnsb/Jv2zee0042+zxIp1ajXFgcH+Y0LN/6kkOVkt8RPZWgEJlvjc7jjLYgz8N7 XBeoubMjWPPYu9bds7sv3HWXJ34= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 615dc2cb9ebaf35aaa3804e3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 06 Oct 2021 15:37:47 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D1734C4360C; Wed, 6 Oct 2021 15:37:46 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id C12DBC43460; Wed, 6 Oct 2021 15:37:45 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 06 Oct 2021 08:37:45 -0700 From: khsieh@codeaurora.org To: Bjorn Andersson Cc: Stephen Boyd , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout In-Reply-To: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> Message-ID: <3dbe0fe48da88af9dee396a85b940e76@codeaurora.org> X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-10-05 19:10, Bjorn Andersson wrote: > On Tue 05 Oct 16:04 PDT 2021, khsieh@codeaurora.org wrote: > >> On 2021-10-05 15:36, Stephen Boyd wrote: >> > Quoting Bjorn Andersson (2021-10-05 14:40:38) >> > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: >> > > >> > > > Quoting Bjorn Andersson (2021-10-04 19:37:50) >> > > > > Found in the middle of a patch from Sankeerth was the reduction of the >> > > > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host >> > > > > is initalized and HPD interrupt start to be serviced, so in the case of >> > > > > eDP this reduction improves the user experience dramatically - i.e. >> > > > > removes 9.9s of bland screen time at boot. >> > > > > >> > > > > Suggested-by: Sankeerth Billakanti >> > > > > Signed-off-by: Bjorn Andersson >> > > > > --- >> > > > >> > > > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go >> > > > re-read the code a couple times to understand that it's waiting 100ms >> > > > times the 'delay' number. Whaaaaat? >> > > > >> > > >> > > I assume you're happy with the current 10s delay on the current >> > > devices, so I don't think we should push for this to be backported. >> > > I have no need for it to be backported on my side at least. >> > > >> > >> > Sure. Fixes tag != backported to stable trees but it is close. >> > >> > > > Reviewed-by: Stephen Boyd >> > > >> dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms >> >> This patch will prevent usb3 from working due to dp driver initialize >> phy >> earlier than usb3 which cause timeout error at power up usb3 phy when >> both >> edp and dp are enabled. > > Can you please help me understand what you mean here, I use this on my > sc8180x with both eDP and USB-C/DP right now. What is it that doesn't > work? Or am I just lucky in some race condition? > > Thanks, > Bjorn > The problem is seen at sc7280. Apple dongle have both hdmi and usb port. plug Apple dongle into type-c, then plug DP into apple's hdmi port and usb mouse into apple's usb port. If edp enabled at this time, then usb mouse will not work due to timeout at phy power up. >> I had prepared a patch (drm/msm/dp: do not initialize combo phy until >> plugin >> interrupt) to fix this problem. >> Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] >> drm/msm/dp: Support up to 3 DP controllers). >> I will submit my patch for review once Bjorn's patches merged in. >> Therefore I would think this patch should go after both Bjorn's >> patches and >> my patch. >> >> >>